Embed search form styling

[tkaczorowski]

Hi Jonathan,

I'd like to make the embedded search field wider and stop the wrap of the search-type-options so they are all on the same line. See here: http://150.108.66.249/hot/searchtest.html . I don't seem to have control of this (if I do, sorry, please explain). This control ideally would be independent of the search box on the heroku pages (currently http://fordham-law-search.herokuapp.com/). This seems possible since the search interfaces appear differently on the two pages. EDIT: also, there is too much padding right and left within the iframe.

[jrochkind]

So, the search interfaces ought not to appear differently on the different pages.

Hmm, they could be different because of the responsive CSS meant to make things different on smaller screens, and then the iframe appears as a smaller screen.

If we can solve the problem without introducing unique styling for the embedded search form, I would prefer that. I think we just need to tweak the responsive small-size-screen styling a bit. I'll look at it with @andymangold

How much wider do you want the search field? You want it to basically be full width?

The search type options are wrapping in ways that seem to me undesirable in the 'heroku pages' screens too; not sure if this changed with your CSS edits, or if it was always this way? Either way, I'll take a look.

[tkaczorowski]

Hi Jonathan,

I want it to appear as it does on the bento page. Note that I will make the search box narrower when we eliminate the FLASH (EDS) option.

I adjusted the CSS for the radio button options slightly as well because it was wrapping too soon relative to the extended width of the search box.

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Wednesday, January 18, 2017 1:14 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Author < author@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

So, the search interfaces ought not to appear differently on the different pages.

Hmm, they could be different because of the responsive CSS meant to make things different on smaller screens, and then the iframe appears as a smaller screen.

If we can solve the problem without introducing unique styling for the embedded search form, I would prefer that. I think we just need to tweak the responsive small-size-screen styling a bit. I'll look at it with @andymangold https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_andymangold&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=MnNcrT5Xna_33sYDz2FsGVWSN2T7NQV4L-W4na1FmjQ&s=R1tKlGEet77q1b4KMEqVDyh6tds2hGcuFyy_eL2ibYA&e=

How much wider do you want the search field? You want it to basically be full width?

The search type options are wrapping in ways that seem to me undesirable in the 'heroku pages' screens too; not sure if this changed with your CSS edits, or if it was always this way? Either way, I'll take a look.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273554992&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=MnNcrT5Xna_33sYDz2FsGVWSN2T7NQV4L-W4na1FmjQ&s=R-gDNrrm_olr8RsMhWkVkxSyITbWLhWU3aWQPPcX_4w&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfkcmnMQOCanWLRbqbvrkPiY-5FZO34ks5rTlZdgaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=MnNcrT5Xna_33sYDz2FsGVWSN2T7NQV4L-W4na1FmjQ&s=hTmeLPW8ao4GrgZUCkP3TueuQfva_cf51hS_Qxb37m0&e= .[image: Image removed by sender.]

[jrochkind]

Hi @tkaczorowski , I've fixed it so in the 'embed' context, the search form, the text input box, the radio buttons, all of it -- will extend the full width it's allowed by it's container.

• you'll want to add some left/right padding to the container you put on the page, since now it's jutting up against it. But this is now under your control.
• I noticed your current demo wrapper has an explicit 'height' set. Recommend not doing this, then the wrapper will grow exactly as large as it needs to be for it's content, which seems to work right I think? You could also have a min-width if you want, but the danger of height is on a very narrow screen the radio buttons might be forced to wrap, and your explicit height will keep the wrapper from being high enough.

Also, in order to get this working nicely, I removed the explicit width you had added to .search-type-options -- I wasn't sure exactly what that was intended to do, and it was interfering a bit with what I needed to do to make things extend properly. But if you tell me the intent there, I can fix it to accomplish your intent too?

Also, some other things that occured to me about the list of radio buttons, not special to the embed context, that i have not implemented, but can work on if you'd like:

• If the radio buttons do have to wrap, it might be better to make sure there isn't an "orphaned" one on the second line by itself, make sure at least two wrap together.
• On very small screens (or a very narrow embed), use a <select> menu instead of radio buttons.

Let me know if the embed is working better for you now?

[tkaczorowski]

Hi Jonathan,

thanks for the info. Disregard my question about my git push error. I found doing “git checkout –“ fixed the “detached head” problem. I then was told to do a git pull which erased my changes – which is ok since you’ve been working on some of the same files.

I’m going to make sure I’m in sync and then see if I need to make any further changes.

If I do want to replace a file locally with the current prod file without detaching my head or otherwise messing up git, what is the correct command?

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 4:03 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

Hi @tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=loarHZBbtsqLhSt-fCUoggrSUfItNrE9yOVLKdBPB_s&e= , I've fixed it so in the 'embed' context, the search form, the text input box, the radio buttons, all of it -- will extend the full width it's allowed by it's container.

• you'll want to add some left/right padding to the container you put on the page, since now it's jutting up against it. But this is now under your control.
• I noticed your current demo wrapper has an explicit 'height' set. Recommend not doing this, then the wrapper will grow exactly as large as it needs to be for it's content, which seems to work right I think? You could also have a min-width if you want, but the danger of height is on a very narrow screen the radio buttons might be forced to wrap, and your explicit height will keep the wrapper from being high enough.

Also, in order to get this working nicely, I removed the explicit width you had added to .search-type-options -- I wasn't sure exactly what that was intended to do, and it was interfering a bit with what I needed to do to make things extend properly. But if you tell me the intent there, I can fix it to accomplish your intent too?

Also, some other things that occured to me about the list of radio buttons, not special to the embed context, that i have not implemented, but can work on if you'd like:

• If the radio buttons do have to wrap, it might be better to make sure there isn't an "orphaned" one on the second line by itself, make sure at least two wrap together.
• On very small screens (or a very narrow embed), use a menu instead of radio buttons.

  Let me know if the embed is working better for you now?

  — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273897714&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=o_VAqbkFl_3138jIF83KzW4fGquCrifY1MqSJ0oORL8&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfpTdIOswJ4-5F4vc-5Fked-5F246eB-2DZxGks5rT8-2DDgaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=-DvoWpxqem3yGyXnG6rBtRiERCL5Rh9hgOyoc6NWWVs&e= .[image: Image removed by sender.]

  jrochkind commented 7 years ago

  If I do want to replace a file locally with the current prod file without detaching my head or otherwise messing up git, what is the correct command?

  I'm actually not certain, I'd have to google for it too, sorry! git command line is not always super intuitive, alas.

  tkaczorowski commented 7 years ago

  Also, in order to get this working nicely, I removed the explicit width you had added to .search-type-options -- I wasn't sure exactly what that was intended to do, and it was interfering a bit with what I needed to do to make things extend properly. But if you tell me the intent there, I can fix it to accomplish your intent too?

  The options take too long to line break. I was trying to make them stay more or less with the width of the search box.

  Tom

  From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 4:03 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

  Hi @tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=loarHZBbtsqLhSt-fCUoggrSUfItNrE9yOVLKdBPB_s&e= , I've fixed it so in the 'embed' context, the search form, the text input box, the radio buttons, all of it -- will extend the full width it's allowed by it's container.

  • you'll want to add some left/right padding to the container you put on the page, since now it's jutting up against it. But this is now under your control.
  • I noticed your current demo wrapper has an explicit 'height' set. Recommend not doing this, then the wrapper will grow exactly as large as it needs to be for it's content, which seems to work right I think? You could also have a min-width if you want, but the danger of height is on a very narrow screen the radio buttons might be forced to wrap, and your explicit height will keep the wrapper from being high enough.

  Also, in order to get this working nicely, I removed the explicit width you had added to .search-type-options -- I wasn't sure exactly what that was intended to do, and it was interfering a bit with what I needed to do to make things extend properly. But if you tell me the intent there, I can fix it to accomplish your intent too?

  Also, some other things that occured to me about the list of radio buttons, not special to the embed context, that i have not implemented, but can work on if you'd like:

  • If the radio buttons do have to wrap, it might be better to make sure there isn't an "orphaned" one on the second line by itself, make sure at least two wrap together.
  • On very small screens (or a very narrow embed), use a
  menu instead of radio buttons.

Let me know if the embed is working better for you now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273897714&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=o_VAqbkFl_3138jIF83KzW4fGquCrifY1MqSJ0oORL8&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfpTdIOswJ4-5F4vc-5Fked-5F246eB-2DZxGks5rT8-2DDgaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=-DvoWpxqem3yGyXnG6rBtRiERCL5Rh9hgOyoc6NWWVs&e= .[image: Image removed by sender.]

[jrochkind]

If I do want to replace a file locally with the current prod file without detaching my head or otherwise messing up git, what is the correct command?

I'm actually not certain, I'd have to google for it too, sorry! git command line is not always super intuitive, alas.

[tkaczorowski]

Also, in order to get this working nicely, I removed the explicit width you had added to .search-type-options -- I wasn't sure exactly what that was intended to do, and it was interfering a bit with what I needed to do to make things extend properly. But if you tell me the intent there, I can fix it to accomplish your intent too?

The options take too long to line break. I was trying to make them stay more or less with the width of the search box.

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 4:03 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

Hi @tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=Tr2HdIcsz8W2LJFMJDnoa-aDnioujr9NF0LEklvQwrM&s=loarHZBbtsqLhSt-fCUoggrSUfItNrE9yOVLKdBPB_s&e= , I've fixed it so in the 'embed' context, the search form, the text input box, the radio buttons, all of it -- will extend the full width it's allowed by it's container.

• you'll want to add some left/right padding to the container you put on the page, since now it's jutting up against it. But this is now under your control.
• I noticed your current demo wrapper has an explicit 'height' set. Recommend not doing this, then the wrapper will grow exactly as large as it needs to be for it's content, which seems to work right I think? You could also have a min-width if you want, but the danger of height is on a very narrow screen the radio buttons might be forced to wrap, and your explicit height will keep the wrapper from being high enough.

Also, in order to get this working nicely, I removed the explicit width you had added to .search-type-options -- I wasn't sure exactly what that was intended to do, and it was interfering a bit with what I needed to do to make things extend properly. But if you tell me the intent there, I can fix it to accomplish your intent too?

Also, some other things that occured to me about the list of radio buttons, not special to the embed context, that i have not implemented, but can work on if you'd like:

• If the radio buttons do have to wrap, it might be better to make sure there isn't an "orphaned" one on the second line by itself, make sure at least two wrap together.
• On very small screens (or a very narrow embed), use a

[jrochkind]

Okay, I thought it was the opposite that you wanted the options not to be breaking so soon!

i can try to make them break at exactly the search box, somehow. happy to consult and/or implement on any other CSS changes you are in the midst of too.

Github usually trims out the quoted email reply when you reply to a github issue comment, but is failing to do so with your email client, alas!

[tkaczorowski]

I’m about to apply a max-width to the search box that may fix the options break as well. Stand by. Trying to use github properly!

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 4:40 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

Okay, I thought it was the opposite that you wanted the options not to be breaking so soon!

i can try to make them break at exactly the search box, somehow. happy to consult and/or implement on any other CSS changes you are in the midst of too.

Github usually trims out the quoted email reply when you reply to a github issue comment, but is failing to do so with your email client, alas!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273906978&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=uJPolWVo6UCxZDEmzbyFvwsdElP4m4SASF62x24CT5E&s=vox9FgP7WX_568v9-q_hkZZbhgHoLlGgjcXctJWL93U&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2Dfrd-2Do5Sga8YxXr1cfcvm-2D3CSKDoQks5rT9gagaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=uJPolWVo6UCxZDEmzbyFvwsdElP4m4SASF62x24CT5E&s=0TV8sfeL75tTNuc6pVIZ149L7ZlfpQ4cQOiw2ymz6DM&e= .[image: Image removed by sender.]

[jrochkind]

Okay. If I were doing this, I would probably remove the width and max-width on .search-field div, and apply them instead to the search field input itself, and then the exact same width and max-width can be applied to the .search-type-options.

I would not apply an additional max-width anywhere without also removing some of the existing ones, or you just have a bunch of max-widths with hard to understand interactions between them.

[jrochkind]

(You can also use variables in SASS when you went the exact same value in two places, rather than copy and pasting the same value multiple places).

[tkaczorowski]

OK I did it. I think it looks good.

See what you think.

Tom

From: Tom Kaczorowski [mailto:tkaczorowski@law.fordham.edu] Sent: Thursday, January 19, 2017 4:42 PM To: 'Fordham-lawlib-bento/fordham-law-search' < reply@reply.github.com>; 'Fordham-lawlib-bento/fordham-law-search' < fordham-law-search@noreply.github.com> Cc: 'Mention' mention@noreply.github.com Subject: RE: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

I’m about to apply a max-width to the search box that may fix the options break as well. Stand by. Trying to use github properly!

Tom

From: Jonathan Rochkind [mailto:notifications@github.com notifications@github.com] Sent: Thursday, January 19, 2017 4:40 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

Okay, I thought it was the opposite that you wanted the options not to be breaking so soon!

i can try to make them break at exactly the search box, somehow. happy to consult and/or implement on any other CSS changes you are in the midst of too.

Github usually trims out the quoted email reply when you reply to a github issue comment, but is failing to do so with your email client, alas!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273906978&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=uJPolWVo6UCxZDEmzbyFvwsdElP4m4SASF62x24CT5E&s=vox9FgP7WX_568v9-q_hkZZbhgHoLlGgjcXctJWL93U&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2Dfrd-2Do5Sga8YxXr1cfcvm-2D3CSKDoQks5rT9gagaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=uJPolWVo6UCxZDEmzbyFvwsdElP4m4SASF62x24CT5E&s=0TV8sfeL75tTNuc6pVIZ149L7ZlfpQ4cQOiw2ymz6DM&e= .[image: Image removed by sender.]

[tkaczorowski]

I only applied a max-width to search-field which seems to also force the options to break with the search interface above them.

You advise against this below. But isn’t the “search field” class targeting the input field? I don’t see an “input field” or some such selector/class.

See what you think about what I’ve done and how it behaves and please advise.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 4:46 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

Okay. If I were doing this, I would probably remove the width and max-width on .search-field div, and apply them instead to the search field input itself, and then the exact same width and max-width can be applied to the .search-type-options.

I would not apply an additional max-width anywhere without also removing some of the existing ones, or you just have a bunch of max-widths with hard to understand interactions between them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273908670&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=tvI8V-fTu_PClHT0ZKVk3pPaTjAC4qH7AJSa3Uj6xMQ&s=kD4i60gYMKIFsIZgxpwjvereO76rSFRO1Rs8X5KT4Tg&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfrJdA2iEAyc4zrB3O57C-5FsiCxNiJks5rT9mzgaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=tvI8V-fTu_PClHT0ZKVk3pPaTjAC4qH7AJSa3Uj6xMQ&s=JWv1gE7k7GalRM7Qc34NxfY4jI9oeFafJucwZL_RrsY&e= .[image: Image removed by sender.]

[jrochkind]

I'm about to be out until next week. How you've done it isn't how I would do it -- it doesn't make them match exactly. I'm also not sure how we make the embed work this way too, since I just removed all the max-widths from the embed! Would have to think about that more. Might actually require changing the structure of the HTML.

But if you're happy, I'm happy. And I'm glad you're getting practice with git and heroku deploy. Also happy to take care of it for you, whatever you like!

[jrochkind]

(The max-width you put in before that I removed was part of what was making the embed behave undesirably, so worth checking how your more recent changes effect the embed. I may not also understand entirely how you desire the embed to lay out).

[tkaczorowski]

Yeah it’s 5PM. Have a great weekend. I’ll continue working on it. I’ll do what you said with the CSS locally and see if I prefer it.

I’m reading an open source book, Pro Git, to better use git. https://git-scm.com/book/en/v2

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 5:01 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

I'm about to be out until next week. How you've done it isn't how I would do it -- it doesn't make them match exactly. I'm also not sure how we make the embed work this way too, since I just removed all the max-widths from the embed! Would have to think about that more. Might actually require changing the structure of the HTML.

But if you're happy, I'm happy. And I'm glad you're getting practice with git and heroku deploy. Also happy to take care of it for you, whatever you like!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273912447&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=OVPu-W3oEvOiVxSqXQXv83kOgmrWWU5PDtMf0CnvvK8&s=w_JlCvrr2i_fIE6xhRS2jNdJ1Ypj5Ts2HO6GuPxAWzA&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfhptKuUnWnp8VEVtr-2DOYxydI1jN-2Dks5rT90qgaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=OVPu-W3oEvOiVxSqXQXv83kOgmrWWU5PDtMf0CnvvK8&s=AI3gAMs8DCLRW-PJ7fh7BuoLruPhB_VY3Y6Xx3GcnzI&e= .[image: Image removed by sender.]

[tkaczorowski]

Will have to investigate the embed further. My iframe isn’t resizing. I must have set a width for it.

http://150.108.66.249/hot/searchtest.html

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Thursday, January 19, 2017 5:02 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Embed search form styling (#42)

(The max-width you put in before that I removed was part of what was making the embed behave undesirably, so worth checking how your more recent changes effect the embed. I may not also understand entirely how you desire the embed to lay out).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_42-23issuecomment-2D273912658&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=K8_czrAjO4KPyxm3PRWzb-0eugCLTY7ayD1wqilURms&s=_jnop61ZIaaYKKu00AumoLfdzuBUghrw2O6vavXB-F8&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfqcY8yDr3MTEW7e16ZPsqPZP-2DBirks5rT91ZgaJpZM4LnJ8W&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=K8_czrAjO4KPyxm3PRWzb-0eugCLTY7ayD1wqilURms&s=m94POgkC6In71Hk-rxOtXNN5N7haep5bdOitcy-0bNw&e= .[image: Image removed by sender.]

[jrochkind]

I'm closing this issue, I assume everything is working to your needs? If not, please reopen.