search

Fordham-lawlib-bento / fordham-law-search

A bento-style search UI for fordham law resources.
0 stars 0 forks source link

Course reserves improvements #44

Open jrochkind opened 7 years ago

jrochkind commented 7 years ago
jrochkind commented 7 years ago

@tkaczorowski if the problem is really just with the word 'exams' being entered on the end of a query and resulting in 0 hits, with that very specific word 'exams', we could strip the word 'exams' from queries on course reserves.

Would of course have unintended consequences if a professor named Ms. Exams ever shows up.

jrochkind commented 7 years ago

@tkaczorowski the architecture of the software (with regard to bg searching) makes it kind of a pain to have the right 'see also' link depending on actual hits anyway. What do you think about just always having both? I think I'm gonna start out that way anyway.

tkaczorowski commented 7 years ago

Do what you think is best and I’ll wait to test.

jrochkind commented 7 years ago

@tkaczorowski the tokenization idea is working, as far as technical implementation. I don't know if it does something useful. Keep in mind if you search smith administrative law, you're going to get a hit on Administrative Law taught by Shugerman, with no smith anywhere in the record -- because it's just combining the results of searching smith alone with the results of searching administrative law alone.

Its going to be some results that look odd, especially to librarians who want to analyse and understand exactly what's going on -- but maybe it'll work out anyway?

jrochkind commented 7 years ago

@tkaczorowski okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

tkaczorowski commented 7 years ago

Hi Jonathan,

i'm in bed sick today. I'll try to look it over. Probably will get feedback to you tomorrow.

Thanks for your good work.

Tom

Manager of Systems & Technology The Maloney Library Fordham University School of Law 150 W 62 St Room 5-119 New York, NY 10023 212-636-6972

On Tue, Feb 7, 2017 at 6:50 PM, Jonathan Rochkind notifications@github.com wrote:

@tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=KGeAjEfH-dRO5TVzBxe4KCjfEhxInEeU7aCfCysD8S8&e= okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_44-23issuecomment-2D278183275&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=lP57ZtIo_uhDbsi1bstSrvVRBeKO-fVdqbpcdQPeM3I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2Dfu9LSZNR4Y8Cp2PlQYL4KFeiH4DHks5raQNPgaJpZM4L57c5&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=DuBFfBxnck4_Z2QY6ct57UB99MvcEOAu7MNpwedQJgE&e= .

tkaczorowski commented 7 years ago

Hi Jonathan,

I’m back in the office. I think the search is working very well, especially given the quirks and limitations of Sierra Classic. The radio button limit functionality is great too.

Can you make these small changes please:

Please change label in the bento to “Full Course Reserves/Exams Browse”. Remember cores is different than reserves.

I’m not seeing the radio buttons with the search box on the cores-only results page.

The responsiveness on 4:3 screens is weird. Please have your programmer see the attached screenshot.

I’ll get people to test on my end.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Tuesday, February 07, 2017 6:51 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

@tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=KGeAjEfH-dRO5TVzBxe4KCjfEhxInEeU7aCfCysD8S8&e= okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_44-23issuecomment-2D278183275&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=lP57ZtIo_uhDbsi1bstSrvVRBeKO-fVdqbpcdQPeM3I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2Dfu9LSZNR4Y8Cp2PlQYL4KFeiH4DHks5raQNPgaJpZM4L57c5&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=DuBFfBxnck4_Z2QY6ct57UB99MvcEOAu7MNpwedQJgE&e= .[image: Image removed by sender.]

jrochkind commented 7 years ago

Hi Tom, I didn't get an attached screen shot.

On Fri, Feb 10, 2017 at 4:19 PM, tkaczorowski notifications@github.com wrote:

Hi Jonathan,

I’m back in the office. I think the search is working very well, especially given the quirks and limitations of Sierra Classic. The radio button limit functionality is great too.

Can you make these small changes please:

Please change label in the bento to “Full Course Reserves/Exams Browse”. Remember cores is different than reserves.

I’m not seeing the radio buttons with the search box on the cores-only results page.

The responsiveness on 4:3 screens is weird. Please have your programmer see the attached screenshot.

I’ll get people to test on my end.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Tuesday, February 07, 2017 6:51 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

@tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURk cqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m= V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=KGeAjEfH- dRO5TVzBxe4KCjfEhxInEeU7aCfCysD8S8&e= okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham- 2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_44- 23issuecomment-2D278183275&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURk cqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m= V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=lP57ZtIo_ uhDbsi1bstSrvVRBeKO-fVdqbpcdQPeM3I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notifications_unsubscribe-2Dauth_AOW- 2Dfu9LSZNR4Y8Cp2PlQYL4KFeiH4DHks5raQNPgaJpZM4L57c5&d=DwMFaQ&c= aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D- VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9 hxxaw_DvqboQc&s=DuBFfBxnck4_Z2QY6ct57UB99MvcEOAu7MNpwedQJgE&e= .[image: Image removed by sender.]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fordham-lawlib-bento/fordham-law-search/issues/44#issuecomment-279068654, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJHOMzmXnpJpIj4LtKaXtNpIMMjdFhIks5rbNRxgaJpZM4L57c5 .

jrochkind commented 7 years ago

I’m not seeing the radio buttons with the search box on the cores-only results page.

You mean the individual results pages, for Course Reserves, and for Website? These weren't designed to have radio buttons, but instead are a search box for just the type of search whose results you are selected. You can press the 'back' link, or go back to your browser tab with the full 'bento' search, to get full bento search.

This could be changed to give you radio buttons even on these 'specific' pages, but I'm not sure we have time left in the budget for it.

Jonathan

On Mon, Feb 13, 2017 at 9:07 AM, Jonathan Rochkind < jonathan@friendsoftheweb.com> wrote:

Hi Tom, I didn't get an attached screen shot.

On Fri, Feb 10, 2017 at 4:19 PM, tkaczorowski notifications@github.com wrote:

Hi Jonathan,

I’m back in the office. I think the search is working very well, especially given the quirks and limitations of Sierra Classic. The radio button limit functionality is great too.

Can you make these small changes please:

Please change label in the bento to “Full Course Reserves/Exams Browse”. Remember cores is different than reserves.

I’m not seeing the radio buttons with the search box on the cores-only results page.

The responsiveness on 4:3 screens is weird. Please have your programmer see the attached screenshot.

I’ll get people to test on my end.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Tuesday, February 07, 2017 6:51 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

@tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__ github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0s PnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7P NYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s= KGeAjEfH-dRO5TVzBxe4KCjfEhxInEeU7aCfCysD8S8&e= okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__ github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw- 2Dsearch_issues_44-23issuecomment-2D278183275&d=DwMFaQ&c=aqM fXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMO bqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9h xxaw_DvqboQc&s=lP57ZtIo_uhDbsi1bstSrvVRBeKO-fVdqbpcdQPeM3I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__ github.com_notifications_unsubscribe-2Dauth_AOW-2Dfu9LSZNR4Y 8Cp2PlQYL4KFeiH4DHks5raQNPgaJpZM4L57c5&d=DwMFaQ&c=aqMfXOEvEJ Qh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-V UZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_ DvqboQc&s=DuBFfBxnck4_Z2QY6ct57UB99MvcEOAu7MNpwedQJgE&e= .[image: Image removed by sender.]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Fordham-lawlib-bento/fordham-law-search/issues/44#issuecomment-279068654, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJHOMzmXnpJpIj4LtKaXtNpIMMjdFhIks5rbNRxgaJpZM4L57c5 .

tkaczorowski commented 7 years ago

Trying to attach file directly on Github.

screenshot

tkaczorowski commented 7 years ago

I just attached it to a new comment on github.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Monday, February 13, 2017 9:07 AM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

Hi Tom, I didn't get an attached screen shot.

On Fri, Feb 10, 2017 at 4:19 PM, tkaczorowski notifications@github.com wrote:

Hi Jonathan,

I’m back in the office. I think the search is working very well, especially given the quirks and limitations of Sierra Classic. The radio button limit functionality is great too.

Can you make these small changes please:

Please change label in the bento to “Full Course Reserves/Exams Browse”. Remember cores is different than reserves.

I’m not seeing the radio buttons with the search box on the cores-only results page.

The responsiveness on 4:3 screens is weird. Please have your programmer see the attached screenshot.

I’ll get people to test on my end.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Tuesday, February 07, 2017 6:51 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

@tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURk cqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m= V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=KGeAjEfH- dRO5TVzBxe4KCjfEhxInEeU7aCfCysD8S8&e= okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham- 2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_44- 23issuecomment-2D278183275&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURk cqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m= V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s=lP57ZtIo_ uhDbsi1bstSrvVRBeKO-fVdqbpcdQPeM3I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notifications_unsubscribe-2Dauth_AOW- 2Dfu9LSZNR4Y8Cp2PlQYL4KFeiH4DHks5raQNPgaJpZM4L57c5&d=DwMFaQ&c= aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D- VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9 hxxaw_DvqboQc&s=DuBFfBxnck4_Z2QY6ct57UB99MvcEOAu7MNpwedQJgE&e= .[image: Image removed by sender.]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/Fordham-lawlib-bento/fordham-law-search/issues/44#issuecomment-279068654 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAJHOMzmXnpJpIj4LtKaXtNpIMMjdFhIks5rbNRxgaJpZM4L57c5

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_44-23issuecomment-2D279401367&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=rCPs_f81S3JS1_Yee5Q0b7nLZHOsuLMch3VjM_npqSI&s=MSsGnbz00U6WQPaoAg21XWunQ0DwBfMCg8rG_xoqpcs&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2Dfuho8ajb2wC1AzihpuKin602Gysnks5rcGOegaJpZM4L57c5&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=rCPs_f81S3JS1_Yee5Q0b7nLZHOsuLMch3VjM_npqSI&s=8byMKowKR_UU6HHLLoe4pQ6gYZSNuhU9CNf7rSRMSSI&e= .[image: Image removed by sender.]

tkaczorowski commented 7 years ago

I see. It makes sense. Let’s not address it further for now.

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Monday, February 13, 2017 9:10 AM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

I’m not seeing the radio buttons with the search box on the cores-only results page.

You mean the individual results pages, for Course Reserves, and for Website? These weren't designed to have radio buttons, but instead are a search box for just the type of search whose results you are selected. You can press the 'back' link, or go back to your browser tab with the full 'bento' search, to get full bento search.

This could be changed to give you radio buttons even on these 'specific' pages, but I'm not sure we have time left in the budget for it.

Jonathan

On Mon, Feb 13, 2017 at 9:07 AM, Jonathan Rochkind < jonathan@friendsoftheweb.com> wrote:

Hi Tom, I didn't get an attached screen shot.

On Fri, Feb 10, 2017 at 4:19 PM, tkaczorowski notifications@github.com wrote:

Hi Jonathan,

I’m back in the office. I think the search is working very well, especially given the quirks and limitations of Sierra Classic. The radio button limit functionality is great too.

Can you make these small changes please:

Please change label in the bento to “Full Course Reserves/Exams Browse”. Remember cores is different than reserves.

I’m not seeing the radio buttons with the search box on the cores-only results page.

The responsiveness on 4:3 screens is weird. Please have your programmer see the attached screenshot.

I’ll get people to test on my end.

Thanks,

Tom

From: Jonathan Rochkind [mailto:notifications@github.com] Sent: Tuesday, February 07, 2017 6:51 PM To: Fordham-lawlib-bento/fordham-law-search < fordham-law-search@noreply.github.com> Cc: tkaczorowski tkaczorowski@law.fordham.edu; Mention < mention@noreply.github.com> Subject: Re: [Fordham-lawlib-bento/fordham-law-search] Course reserves improvements (#44)

@tkaczorowski https://urldefense.proofpoint.com/v2/url?u=https-3A__ github.com_tkaczorowski&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0s PnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7P NYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_DvqboQc&s= KGeAjEfH-dRO5TVzBxe4KCjfEhxInEeU7aCfCysD8S8&e= okay, all points listed on this Github issue are deployed, please consult Github issue (URL at the bottom of this email) to see what was done as a checklist of what to review/consider.

The 'see more' links are always there, not dependent on the results. I think that might actually be okay or even preferable.

I am not sure about the attempt at tokenization. It basically means hits can be included if they match only one word of your query, rather than all of them as someone might expect. But it's doing what you suggested, the implementation is working.

Please review and advise.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__ github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw- 2Dsearch_issues_44-23issuecomment-2D278183275&d=DwMFaQ&c=aqM fXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMO bqD9D-VUZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9h xxaw_DvqboQc&s=lP57ZtIo_uhDbsi1bstSrvVRBeKO-fVdqbpcdQPeM3I&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__ github.com_notifications_unsubscribe-2Dauth_AOW-2Dfu9LSZNR4Y 8Cp2PlQYL4KFeiH4DHks5raQNPgaJpZM4L57c5&d=DwMFaQ&c=aqMfXOEvEJ Qh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-V UZ9gAg0GtO2ab7PNYjU&m=V1EZpHSdv4fn2FPmL3h11cJRxhWtD9hxxaw_ DvqboQc&s=DuBFfBxnck4_Z2QY6ct57UB99MvcEOAu7MNpwedQJgE&e= .[image: Image removed by sender.]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/Fordham-lawlib-bento/fordham-law-search/issues/44#issuecomment-279068654 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAJHOMzmXnpJpIj4LtKaXtNpIMMjdFhIks5rbNRxgaJpZM4L57c5

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Fordham-2Dlawlib-2Dbento_fordham-2Dlaw-2Dsearch_issues_44-23issuecomment-2D279402087&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=_PdLUiLNmhqsmJb0n5MCr3IOGX8zpoducEiq83FuGSo&s=A56I9tyQXGQ8ZfmpYlwGhgaEvqqVQmRkURRkGjrOzDc&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOW-2DfnIr1YCCd1yrlaAIS0wne3qv9gXiks5rcGQ-5FgaJpZM4L57c5&d=DwMFaQ&c=aqMfXOEvEJQh2iQMCb7Wy8l0sPnURkcqADc2guUW8IM&r=ufwSdmS5IZPSMZUMObqD9D-VUZ9gAg0GtO2ab7PNYjU&m=_PdLUiLNmhqsmJb0n5MCr3IOGX8zpoducEiq83FuGSo&s=IhsIwzg9aqANHk6jpKW-JTFbUOmRu6xLL56ghPbfogs&e= .[image: Image removed by sender.]

jrochkind commented 7 years ago

Changed the heading to "FULL COURSE RESERVES/​EXAMS BROWSE", and fixed that responsive breakpoint bug you found (nice catch). Deployed those changes.

Jonathan