search

ForeignGods / ComfyUI-Mana-Nodes

Font Animation, Automatic Speech Recognition and Text to Speech Custom Nodes for ComfyUI
MIT License
209 stars 12 forks source link

Update font2img_node.py #27

Closed Quasimondo closed 5 months ago

Quasimondo commented 5 months ago

I added an optional skip_first_frames input which allows for batch processing of longer videos that otherwise might be too big to fit in memory. What it does is to subtract the skip_first_frames int from the parsed keyframe list to correct for the time-offset.

ForeignGods commented 5 months ago

Thank you, this is a nice feature to have. I think the workflow_example.json will not load properly since the newly added input type is not present there. Do you mind testing this out. Just load the workflow examples with your updated branch and check if it breaks anything. I'll merge it if there is no problem. Or else we would need to update the examples.

Quasimondo commented 5 months ago

Ah yes sorry I had not thought of the example workflow. Theoretically nothing should happen since it is an optional input and the default is 0, but I'll check.

Quasimondo commented 5 months ago

Okay I checked both and there are no errors or other issues that I noticed.