search

ForensicArtifacts / artifacts

Digital Forensics artifact repository
Apache License 2.0
1.03k stars 207 forks source link

Draft: Added VNCPassword definition #588

Open goldenkirbi opened 9 months ago

goldenkirbi commented 9 months ago

Added VNCPasswordFiledefinition for Linux and VNCPasswordRegistryValue for Windows.

Windows definition currently covers registry locations used by RealVNC and TightVNC.

Definitions for Darwin currently not implemented.

Closes https://github.com/ForensicArtifacts/artifacts/issues/587

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (36fb328) 88.03% compared to head (9c10067) 88.03%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## ======================================= Coverage 88.03% 88.03% ======================================= Files 7 7 Lines 443 443 ======================================= Hits 390 390 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joachimmetz commented 9 months ago

@goldenkirbi is this ready for review? Looks like the YAML linter is flagging some issues

data/vnc.yaml
  9:7       error    wrong indentation: expected 4 but found 6  (indentation)
  26:28     error    trailing spaces  (trailing-spaces)
  [31](https://github.com/ForensicArtifacts/artifacts/actions/runs/6853173400/job/18692315988?pr=588#step:7:32):7      error    wrong indentation: expected 4 but found 6  (indentation)
joachimmetz commented 8 months ago

@goldenkirbi note this PR will be affected by https://github.com/ForensicArtifacts/artifacts/pull/592