search

ForensicArtifacts / artifacts

Digital Forensics artifact repository
Apache License 2.0
1.03k stars 207 forks source link

fixing missing * in windows_serv path #619

Open chb2mn opened 5 months ago

chb2mn commented 5 months ago

HKLM\System\CurrentControlSet\Services\ is a listing of all service names and that's about it. Adding a * includes the config data

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.70%. Comparing base (dcb57f8) to head (9c4573b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #619 +/- ## ======================================= Coverage 69.70% 69.70% ======================================= Files 9 9 Lines 769 769 ======================================= Hits 536 536 Misses 233 233 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joachimmetz commented 5 months ago

@chb2mn I recall that the intent of this artifact definition has been to get the names of the services and drivers (https://artifacts-kb.readthedocs.io/en/latest/sources/windows/ServicesAndDrivers.html) only, not the full hierarchy under them. Do you have additional context on why you want to make this change?