Cleanup code formatting with clang and fix small issues. - Githubissues

ForensicITGuy / libpreloadvaccine

Whitelisting LD_PRELOAD libraries using LD_AUDIT

MIT License

61 stars 7 forks source link

Cleanup code formatting with clang and fix small issues. #2

Closed zacbrown closed 5 years ago

zacbrown commented 5 years ago

Summary of work:

Apply clang-format to cleanup code layout.
Add error handling for fstat and read calls.
Clean up boolean assignments.
Define constants for static strings.

Notes

I chose to use clang-format as it's relatively well accepted as a solid code formatter. It enforces things like line length and argument formatting. It can be configured to format differently but I figured something consistent initially was better than nothing.

Testing:

Ran unit tests as part of make on Ubuntu 18.04 LTS. One test failed due to missing test resource /test/test_data/ld.so.preload. Did you forget to check this in @ForensicITGuy?