ForesightMiningSoftwareCorporation / bevy_transform_gizmo

A 3d gizmo for transforming entities in Bevy.
Apache License 2.0
160 stars 40 forks source link

unknown `UpdateSetting` label #25

Closed YoshieraHuang closed 2 years ago

YoshieraHuang commented 2 years ago

I find this warning when I use this great crate:

2022-05-30T07:28:55.784722Z  WARN bevy_ecs::schedule::graph_utils: bevy_transform_gizmo::hover_gizmo wants to be after unknown label: UpdateSettings

So I dive into the code and see this: https://github.com/ForesightMiningSoftwareCorporation/bevy_transform_gizmo/blob/5b27518eda2041f45316cdeef2d90bf15d0b5a33/src/lib.rs#L80-L113

The UpdateSetting label is defined in PostUpdate stage (Line 101) but it is used in PreUpdate stage (Line 87).

Is just deleting Line 87 is ok?