fix: wait the server to be closed when calling agent.close - Githubissues

ForestAdmin / agent-nodejs

🌱 Node.js agent for Forest Admin

GNU General Public License v3.0

66 stars 7 forks source link

fix: wait the server to be closed when calling agent.close #1107

Closed ghusse closed 4 months ago

ghusse commented 4 months ago

Definition of Done

General

[ ] Write an explicit title for the Pull Request, following Conventional Commits specification
[ ] Test manually the implemented changes
[ ] Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

[ ] Consider the security impact of the changes made

codeclimate[bot] commented 4 months ago

Code Climate has analyzed commit 00a76b5c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 83.3% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5% (0.0% change).

View more on Code Climate.

forest-bot commented 4 months ago

:tada: This PR is included in version 1.9.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 4 months ago

:tada: This PR is included in version 1.8.11 :tada:

The release is available on example@1.8.11

Your semantic-release bot :package::rocket:

forest-bot commented 4 months ago

:tada: This PR is included in version 1.39.2 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 4 months ago

:tada: This PR is included in version 1.3.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 4 months ago

:tada: This PR is included in version 1.7.3 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 4 months ago

:tada: This PR is included in version 1.3.9 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 4 months ago

:tada: This PR is included in version 1.14.1 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 3 months ago

:tada: This PR is included in version 1.27.2 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 2 months ago

:tada: This PR is included in version 1.45.0 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: