feat(agent): allow parsing multiple sorting fields

ForestAdmin / agent-nodejs

🌱 Node.js agent for Forest Admin

GNU General Public License v3.0

67 stars 8 forks source link

feat(agent): allow parsing multiple sorting fields #1117

Closed nbouliol closed 6 months ago

nbouliol commented 6 months ago

CU-86by1y3z6

Definition of Done

General

[ ] Write an explicit title for the Pull Request, following Conventional Commits specification
[ ] Test manually the implemented changes
[ ] Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

[ ] Consider the security impact of the changes made

forest-bot commented 6 months ago

Task linked: CU-86by1y3z6 Inbox multiple sort - Story #6 - Implement double sort on agent nodejs v2 😏

codeclimate[bot] commented 6 months ago

Code Climate has analyzed commit 96596e70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5%.

View more on Code Climate.

nbouliol commented 6 months ago

Request:

http://localhost:3311/forest/buns?timezone=Europe/Paris&fields[buns]=id&filters={"field":"flavor","operator":"equal","value":"chicken"}&page[number]=1&page[size]=10&segmentName=chicken&sort=buns_count,-is_good,flavor
&sort=buns_count,-is_good,flavor

Generated query:

SELECT "id"
FROM "buns" AS "buns"
WHERE (
        "buns"."flavor" = 'chicken'
        AND (
            "buns"."id" != 6
            AND "buns"."id" != 395
        )
    )
ORDER BY "buns"."buns_count" ASC,
    "buns"."is_good" DESC,
    "buns"."flavor" ASC
LIMIT 10 OFFSET 0;

forest-bot commented 6 months ago

:tada: This PR is included in version 1.9.9 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

forest-bot commented 6 months ago

:tada: This PR is included in version 1.8.17 :tada:

The release is available on example@1.8.17

Your semantic-release bot :package::rocket:

forest-bot commented 6 months ago

:tada: This PR is included in version 1.40.0 :tada:

The release is available on npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: