fix(type): add FilterOperator enum

ForestAdmin / forest-express-sequelize

🌱 Express/Sequelize agent for Forest Admin to integrate directly to your existing Express/Sequelize backend application.

https://www.forestadmin.com

GNU General Public License v3.0

191 stars 47 forks source link

fix(type): add FilterOperator enum #1040

Closed JustinMartinDev closed 1 year ago

JustinMartinDev commented 1 year ago

Definition of Done

General

Proposal based on filter-parser and filter-date-parser

[x] Write an explicit title for the Pull Request, following Conventional Commits specification
[x] Test manually the implemented changes
[x] Validate the code quality (indentation, syntax, style, simplicity, readability)
[x] Ensure that Types have been updated according to your changes (if needed)

Security

[x] Consider the security impact of the changes made

JustinMartinDev commented 1 year ago

news @jeffladiray ?

jeffladiray commented 1 year ago

Yes, sorry for the delayed response. It seems like you are missing quite a few operators, especially the one related to Date filtering (The complete list of operators supported is available here (On our new agent).

If you feel like updating this contribution with these, I'll happily merge it. Otherwise, I can file a ticket on our end.

JustinMartinDev commented 1 year ago

I amend my previous commit to include operator of this fie https://github.com/ForestAdmin/forest-express/blob/main/src/services/base-operator-date-parser.js

@jeffladiray fixed

jeffladiray commented 1 year ago

Thanks you for this contribution 🙌

forest-bot commented 1 year ago

:tada: This PR is included in version 9.0.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: