ForestAdmin / forest-express

🧱 Dependency of Express Lianas for Forest Admin
GNU General Public License v3.0
72 stars 21 forks source link

Publish ip-utils as a package to avoid the need for git when installing forest-express #169

Closed Caerbannog closed 5 years ago

Caerbannog commented 6 years ago

Expected behavior

npm install forest-express should work on machines where git is not installed. Example: a Dockerfile based on Alpine Linux.

Actual behavior

Error message: error Couldn't find the binary git

Cause

Here is the dependency that is locked on a git version: https://github.com/ForestAdmin/forest-express/blob/bc2bfa121685b79d94271136e919769442f0289b/package.json#L34

rodrigo4244 commented 6 years ago

Same here :+1:

ozomer commented 5 years ago

This is relevant for anyone that uses dockers based on node-alpine. You have to add a line like: RUN apk add --no-cache git to install git on the image.

Kerumen commented 5 years ago

This is blocking my installation on now (https://github.com/zeit/now-builders/issues/49). Can you do something please?

arnaudbesnier commented 5 years ago

Hi @Caerbannog, @rodrigo4244, @Kerumen this is now fixed in the latest liana versions. Thank you for your patience.