search

ForestAdmin / forest-express

🧱 Dependency of Express Lianas for Forest Admin
GNU General Public License v3.0
72 stars 21 forks source link

Make the integration system pluggable #60

Open louisremi opened 7 years ago

louisremi commented 7 years ago

Hi,

I'd like to integrate InvoiceNinja into Forest, by taking inspiration on the Stripe integration. After digging around the integration code, I realize it will be difficult for me to do that without forking forest-express. It seems it could be easy to change https://github.com/ForestAdmin/forest-express/blob/devel/integrations/index.js#L5 to initialize modules with values passed through the liana options.

Before I open a pull request, I'd like to know if you would be willing to make the integration system pluggable.

Thanks :-)

arnaudbesnier commented 7 years ago

Hey @louisremi , that's an interesting use case! Why wouldn't you fork the repository to add InvoiceNinja integration? The community could be happy to use your contribution.

louisremi commented 7 years ago

I'm happy to open-source my integration, but it will probably not be as complete as the Stripe integration, so I'm not sure it's a good idea to make it an official integration just yet :-)

On 27 March 2017 at 10:37, Arnaud Besnier notifications@github.com wrote:

Hey @louisremi https://github.com/louisremi , that's an interesting use case! Why wouldn't you fork the repository to add InvoiceNinja integration? The community could be happy to use your contribution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ForestAdmin/forest-express/issues/60#issuecomment-289389118, or mute the thread https://github.com/notifications/unsubscribe-auth/AACZzkcOH31mcWCszyYOP-C4JD9xoB_1ks5rp3VHgaJpZM4Moc5V .