ForestAdmin / forest-express

🧱 Dependency of Express Lianas for Forest Admin
GNU General Public License v3.0
72 stars 21 forks source link

feat: add support for data-based conditions on smart action trigger, approval requirement and authorization to approve #955

Closed Thenkei closed 1 year ago

Thenkei commented 1 year ago

Definition of Done

General

Security

Thenkei commented 1 year ago

Well, we have more work to do to compute allowed role ids without having scopes interfering.

Thenkei commented 1 year ago

Awaiting @forestadmin/forestadmin-client newer version.

Thenkei commented 1 year ago

I've tested the workflow. It working smoothly on my end. :)

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit eb955761 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 3

The test coverage on the diff in this pull request is 97.1% (70% is the threshold).

This pull request will bring the total coverage in the repository to 61.3% (0.8% change).

View more on Code Climate.

ghusse commented 1 year ago

Linked to CU-35d7gv6

forest-bot commented 1 year ago

Task linked: CU-35d7gv6 Story #6 [forest-express] check conditions on data when triggering a smart action

forest-bot commented 1 year ago

Task linked: CU-35d7h2b Story #13 - [forest-express] check if an action requires an approval

forest-bot commented 1 year ago

Task linked: CU-35d7h4d Story #18 - [forest-express] check if an action can be approved

forest-bot commented 1 year ago

:tada: This PR is included in version 10.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: