ForestAdmin / forest-express

🧱 Dependency of Express Lianas for Forest Admin
GNU General Public License v3.0
72 stars 21 forks source link

fix: allow nested models named attributes to be serialized #959

Closed fakalit closed 1 year ago

fakalit commented 1 year ago

https://community.forestadmin.com/t/collections-unable-to-preview-collection-items-due-to-serialization-issues/5359/4

If there a nested model named "attributes" serialization fails. While the actual bug seems to be in JSONSerializer (it makes the assumption of: an object having the key "attributes" means it's a schema.), adding the words "attributes" to the reserved keywords on the forest side seems to fix this problem.

Definition of Done

General

Security

SkyHuss commented 1 year ago

Hello again ! The fix has been released #961 , so I close this PR, thanks again for your contribution 🙏