ForestAdmin / forest-rails

💎 Ruby on Rails agent for Forest Admin to integrate directly to your existing Ruby on Rails backend application.
https://www.forestadmin.com
GNU General Public License v3.0
374 stars 77 forks source link

How do I stop the ForestAdmin Background Process #608

Open klondikemarlen opened 1 year ago

klondikemarlen commented 1 year ago

Expected behavior

Once I boot the app, I can set an environment variable that prevents ForestAdmin from generating schema changes. I'm currently using

export FOREST_DISABLE_AUTO_SCHEMA_APPLY=true

but this does not prevent ForestAdmin schema from generating.

Actual behavior

Once I boot the app, the ForestAdmin schema generator starts running, and if my schema is out of date it creates some unstaged changes in git. I can't figure out how to get it to stop generating changes, even when I close my app.

This is particularly annoying because it generates changes every time I switch branches, and then blocks me from switching again until I clear the changes that are generated.

e.g.

  1. git checkout main
  2. git checkout some-other-branch
  3. Oh no! I ForestAdmin just generated some changes and I can't switch branches!
  4. git reset --hard origin/main
  5. git checkout some-other-branch (again)
  6. git checkout some-other-other-branch
  7. Oh no! I ForestAdmin just generated some changes and I can't switch branches!
  8. git reset --hard origin/some-other-other-branch
  9. git checkout some-other-other-branch (again)

Context

matthv commented 1 year ago

Hello @klondikemarlen,

Sorry for my late reply. The environment variable FOREST_DISABLE_AUTO_SCHEMA_APPLY is dedicated to disable the sending of the schema to our api.

The only way to disable the generation of the .forestadmin-schema.json file is to switch to production mode.

https://github.com/ForestAdmin/forest-rails/blob/main/lib/forest_liana/bootstrapper.rb#L83-L87

klondikemarlen commented 1 year ago

@matthv Thanks for the explanation.

Since I'm developing, setting my entire Rails environment to production, isn't feasible.

Would it be possible to add a feature so that I could do

export FOREST_DISABLE_AUTO_SCHEMA=true

and it would turn off ForestAdmin schema generation?

matthv commented 1 year ago

I have just added your request to our ProductBoard.

jjf21 commented 10 months ago

Any news on this topic ?