ForestAdmin / lumber

Install Forest Admin in minutes.
https://www.forestadmin.com
MIT License
2.07k stars 106 forks source link

Update is not possible when using SSL #234

Closed Ni0rd closed 5 years ago

Ni0rd commented 5 years ago

Expected behavior

lumber update should update the app models

Actual behavior

lumber update crashes.

Failure Logs

> Cannot connect to the database due to the following error:
> SequelizeConnectionError: no pg_hba.conf entry for host "89.3.25.84", user "gexvagloeoizgi", database "d91aosrmq4610l", SSL off

Context

I think the relevant part is : https://github.com/ForestAdmin/lumber/blob/6191eedc4ed5fa729ea9cbeaa2b161e5ae1ffe28/lumber-update.js#L25-L28

If you compare with the (working) lumber generate : https://github.com/ForestAdmin/lumber/blob/6191eedc4ed5fa729ea9cbeaa2b161e5ae1ffe28/lumber-generate.js#L29-L34

I think the SSL option is not used.

coffenbacher commented 5 years ago

I'm just trying out Lumber and ran into this - it's kind of concerning that such a simple bug has had no activity for a month...

Edit: I messed around and made a really bad fixed version if anyone needs it: yarn add global https://github.com/coffenbacher/lumber#devel. got confused which version I was running locally so there's some extra garbage in there but it works.

arnaudbesnier commented 5 years ago

Hi guys, sorry for the late response. Let me prioritise investigations on this issue for this week.

coffenbacher commented 5 years ago

Sure, no problem. I think it's a really simple one, the suggested fix in the bug report basically worked for me.

arnaudbesnier commented 5 years ago

Fixed in the new Lumber version (v2.3.5). Thanks for your help guys!

coffenbacher commented 5 years ago

Awesome, thank you @arnaudbesnier!