search

ForestAdmin / lumber

Install Forest Admin in minutes.
https://www.forestadmin.com
MIT License
2.08k stars 106 forks source link

[+] Technical - Test on mssql 2017 and 2019 #379

Closed slimee closed 4 years ago

slimee commented 4 years ago

(?) P1 - Lumber - Generate command fails on a MySQL v5.6 database

rap2hpoutre commented 4 years ago

Just before I review it carefully: what was the consensus on this PR: https://github.com/ForestAdmin/lumber/pull/378? "Mssql2017" seems better than "OldMssql" to me but I don't want to pollute with a pointless review if something else was decided elsewhere. Should we change to MIN and MAX?

slimee commented 4 years ago

Just before I review it carefully: what was the consensus on this PR: #378? "Mssql2017" seems better than "OldMssql" to me but I don't want to pollute with a pointless review if something else was decided elsewhere. Should we change to MIN and MAX?

Yes I will set it on MIN/MAX 👍