Closed albertinator closed 4 years ago
A new version of lumber has just been released thanks to your suggestion: https://github.com/ForestAdmin/lumber/pull/464#issuecomment-709057240 🎉
Thank you for your feedback! 🙏
Feel free to re-open this issue if you have any issue!
Expected behavior
Expect
services.app
indocker-compose.yml
to source environment variables from.env
.Actual behavior
It was surprising to see that our
DATABASE_URL
was directly added to theservices.app.environment
property (hard-coded) when thedocker-compose.yml
was generated bylumber
.Failure Logs
Not a failure, just a security concern because many users likely will create a Git repo out of this and the
docker-compose.yml
would part of that codebase with aDATABASE_URL
hard-coded in.I wouldn't have known this if I didn't thoroughly inspect every file generated by
lumber
.Context