fix(command generate): fix generation of project with postgres on node 14.4 - Githubissues

ForestAdmin / lumber

Install Forest Admin in minutes.

https://www.forestadmin.com

MIT License

2.08k stars 106 forks source link

fix(command generate): fix generation of project with postgres on node 14.4 #446

Closed VincentMolinie closed 4 years ago

VincentMolinie commented 4 years ago

Pull Request checklist:

[ ] Write an explicit title for the Pull Request, following Conventional Commits specification
[ ] Create automatic tests
[ ] No automatic tests failures
[ ] Test manually the implemented changes
[ ] Review my own code (indentation, syntax, style, simplicity, readability)
[ ] Wonder if you can improve the existing code

VincentMolinie commented 4 years ago

Task linked: CU-66r9p7 P2 - Impossible to connect to postgresql database using NodeJS v14.4

SteveBunlon commented 4 years ago

Screenshot 2020-07-01 at 18 19 16

This is what I've got using node version 14.5.0. We must have another issue elsewhere.

Can you confirm an install work on your machine using node > 14 ?

VincentMolinie commented 4 years ago

st have another

I tried with node 14.4 and it is working fine 🤔. Let me try with 14.5

VincentMolinie commented 4 years ago

It worked fine on mongodb (The warning was about mongo), it was it seems just a warning. I upgraded mongo and the warning disappeared 😉

SteveBunlon commented 4 years ago

It has nothing to do with mongodb. I tested it again and it works, I must have missed my first test.

You can remove the Mongodb fix if you wanna strictly stick to the PR name

forest-bot commented 4 years ago

:tada: This PR is included in version 3.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: