ForestClaw / forestclaw

Quadtree/octree adaptive PDE solver based based on p4est.
http://www.forestclaw.org
BSD 2-Clause "Simplified" License
58 stars 22 forks source link

Time dependent Boundary conditions #118

Closed donnaaboise closed 6 years ago

donnaaboise commented 6 years ago

If the boundary condition is obtained via a solution to an ODE, the time stepping should be done in b4step2, not in bc2. The reason is that the physical boundary conditions are called multiple times, and this will screw up the time stepping.

donnaaboise commented 6 years ago

The time step 'dt' is not passed to bc2 in clawpack 5.0 or amrclaw 5.0, so only passed in Clawpack 4.6. Still not clear why someone would use dt in bc2, but in ForestClaw, we set this to 1e99, and don't allow the user to set it.