search

ForestClaw / forestclaw

Quadtree/octree adaptive PDE solver based based on p4est.
http://www.forestclaw.org
BSD 2-Clause "Simplified" License
58 stars 21 forks source link

Feature p8est #184

Closed cburstedde closed 2 years ago

cburstedde commented 2 years ago

This is the first batch of changes generalizing ForestClaw to use p8est, the full 3D adaptive octree.

I've worked through forestclaw2d.c except for the indirect ghost exchange. fclaw2d_convenience.c is partially generalized, some more work to do. The edge transformations are not there yet.

There is the danger of regressions in the 2D face/corner transformations, where the code update was non-trivial to accommodate the generalization to 3D. The tests are running fine so this looks ok on my end.

cburstedde commented 2 years ago

This is now a reasonable scheme of naming files for moving to full 3D.

We have dimension-independent-code in fclaw* and dimension-dependent previous and enhanced fclaw2d code and new fclaw3d_ code.

Quite a bit of the code in the fclaw2d files may be made dimension-independent and moved into the corresponding fclaw files.

cburstedde commented 2 years ago

For the time being, current 2D and extruded code continues to work while the new code is being further developed. Old 2D / extruded, new 2D / 3D coexist in the same code base, and it is possible to write and enhance applications using either scheme.