(clawpack/disk,filament) Remove references to clawpatch and fclaw options

ForestClaw / forestclaw

Quadtree/octree adaptive PDE solver based based on p4est.

http://www.forestclaw.org

BSD 2-Clause "Simplified" License

58 stars 22 forks source link

(clawpack/disk,filament) Remove references to clawpatch and fclaw options #208

Closed donnaaboise closed 2 years ago

donnaaboise commented 2 years ago

Remove hack that required reading option attributes and instead check in actual applications Applications affected :

clawpack/advection/2d/disk
clawpack/advection/2d/filament

Did I miss any?

scottaiton commented 2 years ago

Need to be updated:

advection/2d/radial
advection/2d/replicated
advection/3d/filament
shallow/2d/radialdam

donnaaboise commented 2 years ago

Several applications need to do an options check that involves more than one options package. This PR adds that functionality to the applications listed above. To make this work, I added a "print_options" function to fclaw_base that can be called outside of the parsing routines. This will get called after this final options checking.

donnaaboise commented 2 years ago

This is ready to merge