ForestClaw / forestclaw

Quadtree/octree adaptive PDE solver based based on p4est.
http://www.forestclaw.org
BSD 2-Clause "Simplified" License
57 stars 21 forks source link

CMake improvement for consumption of libsc, p4est and Zlib #295

Closed scivision closed 2 weeks ago

scivision commented 6 months ago

NOTE: this may be desired as a squash commit due to back-and-forth implementations that aren't useful to preserve in commit history.

This uses FetchContent and CMake cache variables with Git Submodules to propagate variables from child to parent projects reliably and cleanly. It avoids retesting system capabilities when child projects have already done so e.g. SC_HAVE_UNISTD_H

TODO: I need to fix Thunderegg consumption

scottaiton commented 5 months ago

Couple of issues here: