search

ForestryMC / Binnie

Minecraft addons for the Forestry mod. Extra Bees, Extra Trees, Genetics, and more.
https://minecraft.curseforge.com/projects/binnies-mods
Other
69 stars 59 forks source link

AlcoholDrinking correct implementation #484

Closed RusTit closed 6 years ago

RusTit commented 6 years ago

The current implementation does not work at all. After drinking (actually eating) the item disappeared. I made an implementation based on the ItemFood source code Please check carefully for possible errors.

RusTit commented 6 years ago

Finally, you can get drunk =) P.S. it was possible before too, but complicated, because of item disappearing. 2018-03-27_22 36 29 2018-03-27_22 36 30

RusTit commented 6 years ago

https://github.com/ForestryMC/Binnie/blob/6fa570987ac9a73cd6dbb205f06dc8d0de70ca6c/extratrees/src/main/java/binnie/extratrees/items/ItemDrink.java#L49 By the way, it seems to me that this is incorrect (and not convenient). Maybe it should be 64?

mezz commented 6 years ago

I don't think drinking a stack of alcohol is a good idea, holding 1 glass and refilling it from a source of alcohol makes sense to me. :)

RusTit commented 6 years ago

Ok =)

mezz commented 6 years ago

Fluid handlers also become more tricky when there is more than 1 item per stack, since you just want to drain one at a time. This code would become a bit more complex.