ForestryMC / Binnie

Minecraft addons for the Forestry mod. Extra Bees, Extra Trees, Genetics, and more.
https://minecraft.curseforge.com/projects/binnies-mods
Other
69 stars 78 forks source link

NullPointerException when Climatizer placed with HWYLA active #548

Closed mopsyd closed 5 years ago

mopsyd commented 5 years ago

This is a rehash of an an issue posted on the HWYLA, which turned out to be upstream.

Issue Description: See stack trace: https://paste.dimdev.org/owinisosaj.mccrash

This error threw over 1,000 times within two seconds (placed and immediately broke suspect block). It is difficult to tell exactly how many instances of the error occurred, because the log stopped recording due to the volume of them almost immediately.

What happens: Causes massive volume of NullPointerExceptions, which flood the log beyond the point of being able to capture additional messages. Also causes a huge amount of lag in game (with the Vanilla Fix mod), or immediate crash (without vanilla fix mod).

What you expected to happen: Expected to be able to place blocks without causing game crashes due to Hwyla failing to render the info for them.

Steps to reproduce: Place a Climatiser from Binnie's Genetics while Hwyla is installed. See stacktrace for possible other mods causing conflict. Affected Versions (Do not use "latest"): Hwyla: Hwyla-1.8.26-B41_1.12.2.jar Minecraft: 1.12.2 Forge: 14.23.4.2750 Possible Conflicting Mods (Provide their version, as well) See provided stacktrace.

Diagnosis from Hwyla team:

Binnie's is returning true in hasCapability(...) but null in getCapability(...)

https://github.com/TehNut/HWYLA/issues/126#issuecomment-416070609

temp1011 commented 5 years ago

This is fixed in the latest version of Binnie's I believe (https://github.com/ForestryMC/Binnie/pull/527)

mopsyd commented 5 years ago

Awesome. Is there a release build containing this patch as of yet, or would I need to build from source?

temp1011 commented 5 years ago

https://minecraft.curseforge.com/projects/binnies-mods/files/2583495 should work