search

ForestryMC / Binnie

Minecraft addons for the Forestry mod. Extra Bees, Extra Trees, Genetics, and more.
https://minecraft.curseforge.com/projects/binnies-mods
Other
69 stars 77 forks source link

Tree generation code rewrite #621

Closed nstearns96 closed 4 years ago

nstearns96 commented 4 years ago

Cleaned up import Fixed pod textures Downgraded Forestry version Fixed trees not generating pods (Fixes: #608 ) Fixed trees with 2x2 or more girth not generating correctly (Fixes: #278 )

I apologize for the massive file change count, I optimized the imports using Intellij's automatic process which I think would be good to use going forward to keep the imports consistent

mezz commented 4 years ago

I will run optimize imports as a separate commit so that it is not included in this PR.

mezz commented 4 years ago

It looks like there are many conflicts because we do not use import with *. I will update your branch to match.

mezz commented 4 years ago

This is still a lot to look over, can you provide screenshots to show the changes?

nstearns96 commented 4 years ago

In the game, the only things that should have changed are the two issues I referenced. As far as the actual code base goes, this allows us to have total control over the trunk, leaves, and fruit pods of each tree type, which is what I wanted in order to change the appearance of the trees, which I have not yet done.

mezz commented 4 years ago

Ok, thanks. looks good to me