ForestryMC / ForestryMC

Source code for Forestry (Minecraft mod).
https://forestryforminecraft.info/
Other
478 stars 226 forks source link

Server/client freezes and stops when alveary has territory upgrade in Electrical Stimulator block #1812

Open Krysinski opened 7 years ago

Krysinski commented 7 years ago

Server core: thermos (latest) mc version: 1.7.10 forestry: 4.2.16 some from modlist: gregtech 5.09.29, binniemod 2.0.21 That is a major part of log: forestry.apiculture.flowers.FlowerRegistry.getAcceptedFlowerCoordinates(FlowerRegistry.java:174) forestry.apiculture.HasFlowersCache.hasFlowers(HasFlowersCache.java:66) forestry.apiculture.BeekeepingLogic.canWork(BeekeepingLogic.java:208) forestry.apiculture.multiblock.AlvearyController.updateServer(AlvearyController.java:231) forestry.core.multiblock.MultiblockControllerBase.updateMultiblockEntity(MultiblockControllerBase.java:423) forestry.core.multiblock.MultiblockWorldRegistry.tickStart(MultiblockWorldRegistry.java:82) forestry.core.multiblock.MultiblockRegistry.tickStart(MultiblockRegistry.java:29) forestry.core.multiblock.MultiblockServerTickHandler.onWorldTick(MultiblockServerTickHandler.java:20) cpw.mods.fml.common.eventhandler.ASMEventHandler_354_MultiblockServerTickHandler_onWorldTick_WorldTickEvent.invoke(.dynamic) cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) cpw.mods.fml.common.FMLCommonHandler.onPreWorldTick(FMLCommonHandler.java:273) net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:957) net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:432) net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:841) net.minecraft.server.MinecraftServer.run(MinecraftServer.java:693) java.lang.Thread.run(Thread.java:745)

mezz commented 7 years ago

Thanks for the report! Please upload the entire log to https://gist.github.com/ and link it here.

Krysinski commented 7 years ago

https://gist.github.com/Krysinski/fdbbf89922d7068f661a40f28eb5dec4

Alirex commented 7 years ago

Before this error appeared, I placed a vanilla "marshy" princess and a "diamond" drone (GregTech) (drone created with special genes via Genetics) in "Alveary"

Krysinski commented 7 years ago

"diamond" drone can be not from GT (Waila mod can lie)

Alirex commented 7 years ago

Waila say this is "Forestry" bee. And for drone from "ExtraBees" Waila say this is "Forestry" bee too.

Krysinski commented 7 years ago

There are 2 drones. /mt hand first (blue contour) item drone:

.withTag({MaxH: 30, Health: 30, IsAnalyzed: 1 as byte, Genome: {Chromosomes: [{UID1: "extrabees.species.diamond", UID0: "extrabees.species.diamond", Slot: 0 as byte}, {UID1: "forestry.speedSlowest", UID0: "forestry.speedSlowest", Slot: 1 as byte}, {UID1: "forestry.lifespanShort", UID0: "forestry.lifespanShort", Slot: 2 as byte}, {UID1: "forestry.fertilityLow", UID0: "forestry.fertilityLow", Slot: 3 as byte}, {UID1: "forestry.toleranceBoth2", UID0: "forestry.toleranceBoth2", Slot: 4 as byte}, {UID1: "forestry.boolTrue", UID0: "forestry.boolTrue", Slot: 5 as byte}, {UID1: "forestry.toleranceBoth2", UID0: "forestry.toleranceBoth2", Slot: 7 as byte}, {UID1: "forestry.boolTrue", UID0: "forestry.boolTrue", Slot: 8 as byte}, {UID1: "forestry.boolTrue", UID0: "forestry.boolTrue", Slot: 9 as byte}, {UID1: "extrabees.flower.rock", UID0: "extrabees.flower.rock", Slot: 10 as byte}, {UID1: "forestry.floweringSlowest", UID0: "forestry.floweringSlowest", Slot: 11 as byte}, {UID1: "forestry.territoryAverage", UID0: "forestry.territoryAverage", Slot: 12 as byte}, {UID1: "forestry.effectNone", UID0: "forestry.effectNone", Slot: 13 as byte}]}}) /mt hand second (white contour) item drone: .withTag({MaxH: 20, Health: 20, IsAnalyzed: 1 as byte, Genome: {Chromosomes: [{UID1: "forestry.speciesDiamond", UID0: "forestry.speciesDiamond", Slot: 0 as byte}, {UID1: "forestry.speedSlowest", UID0: "forestry.speedSlowest", Slot: 1 as byte}, {UID1: "forestry.lifespanShorter", UID0: "forestry.lifespanShorter", Slot: 2 as byte}, {UID1: "forestry.fertilityNormal", UID0: "forestry.fertilityNormal", Slot: 3 as byte}, {UID1: "forestry.toleranceNone", UID0: "forestry.toleranceNone", Slot: 4 as byte}, {UID1: "forestry.boolFalse", UID0: "forestry.boolFalse", Slot: 5 as byte}, {UID1: "forestry.toleranceNone", UID0: "forestry.toleranceNone", Slot: 7 as byte}, {UID1: "forestry.boolFalse", UID0: "forestry.boolFalse", Slot: 8 as byte}, {UID1: "forestry.boolFalse", UID0: "forestry.boolFalse", Slot: 9 as byte}, {UID1: "forestry.flowersVanilla", UID0: "forestry.flowersVanilla", Slot: 10 as byte}, {UID1: "forestry.floweringAverage", UID0: "forestry.floweringAverage", Slot: 11 as byte}, {UID1: "forestry.territoryAverage", UID0: "forestry.territoryAverage", Slot: 12 as byte}, {UID1: "forestry.effectNone", UID0: "forestry.effectNone", Slot: 13 as byte}]}})
Krysinski commented 7 years ago

Ok, i found that diamond dron was from GregTech.

Krysinski commented 7 years ago

We do some tests in single game:

  1. Client hang also with pure forge
  2. No matter wich bee used in alveary (not GT issue)
  3. Game start freezing when alveary has a queen
  4. the reason of issue is electric stimulator block in alveary structure with circuit installed. Circuit must make "territory upgrade". Alveary was tested with:
    • 4 stimulator block and 4 "territory" intricate circuits inside (1 lamp 50% 4=200% for 1 circuit), so i guess 4 stimublock give 200 4=800% territory upgrade
    • 4 stimulator block and 4 "flowering" intricate circuits inside I suppose that "forestry.apiculture.flowers.FlowerRegistry.getAcceptedFlowerCoordinates(FlowerRegistry.java:174)" try to "calculate" every f*ckin flower at +800% area. People say that wasnt issue before we update binniemod from old "last version" (with binnie patcher for forestry 4.2): binnie-mods-2.0-pre14
temp1011 commented 5 years ago

I would say this is https://github.com/ForestryMC/ForestryMC/issues/2167. The process is just accelerated due to increased area.

TherminatorX commented 4 years ago

Hey there, still having this bug in 2020 as of Binne's version 2.5.1.200 and Forestry 5.8.2.414