search

ForestryMC / ForestryMC

Source code for Forestry (Minecraft mod).
https://forestryforminecraft.info/
Other
479 stars 229 forks source link

Giant Sequoia pollen not being offered #2233

Open AntonLM opened 6 years ago

AntonLM commented 6 years ago

I don't know if this is a bug or just a RNG issue. Please guide me if this should be somewhere else.

I've traded with 200-300 Arborists, through to the last tier of each, and have been offered lots of Giant Sequoia wood and planks, but no GS pollen (or saplings). Has something crept into the code of the current version of Forestry so that GS pollen etc will never be offered? I would feel very foolish if I were furiously trading for something that I will never get!

[I'm playing the current version of the DW20 modpack - forestry_1.12.2-5.8.1.325.jar .]

Thank you for reporting!

For issues:

temp1011 commented 6 years ago

If the sapling if complex to breed then it won't be offered as a trade, probably for balance reasons. However, this seems like something it could be reasonable to add to the config.

AntonLM commented 6 years ago

The literature suggests that you should be able to get GS pollen at least, which you use to tap on Coast Sequoia leaves to get GS (mixed?) sapling. But pollen is not offered either.

AntonLM commented 6 years ago

I've looked in my client's Forestry config, and my MP server admin has done a grep on his configs, but we have found no reference to "sequoia". Are we looking i the wrong place?

temp1011 commented 6 years ago

I don't think there is anything in the config about it at the moment. It seems from a glance at the code that it should he possible to get giant sequoia through trades, so maybe there is a bug. I will try and test it today.

temp1011 commented 6 years ago

trade I was able to get a sequoia trade by setting a breakpoint on the random call and changing the value chosen from the list (essentially debugging trick to bypass the dice roll). It isn't very likely though (1 in 35 with just forestry and is later tier). As DW20 has Binnie's installed too it means that the chance will be even worse. EDIT: I just tried with Binnies and the chance now is 1 in 132

AntonLM commented 6 years ago

I have totally no idea how to do any of that (your first sentence)! Way over my head, I'm afraid.

temp1011 commented 6 years ago

Don't worry, you're not meant to do that, it was more me rambling. It just seems like the chance is a bit low. However, not getting any in 300 arborists seems a bit unlucky.

AntonLM commented 6 years ago

I know that RNGs can be vindictively quirky sometimes, seeming almost to know what you want and mischievously denying it. I'm still willing to grind away at it if I can be sure that something like a misplaced comma hasn't crept into the code resulting in GS pollen never being offered. It would also be comforting to know more or less what the likelihood of GS pollen is.

AtomicWaffle14 commented 5 years ago

I was able to get one after about 30 arborists. Supposedly its a 1/35 chance for an arborist to sell it. With an automated villager breeder it probably would be feasible in survival. With Binnie's mods however, definitely not.