search

ForestryMC / MagicBees

Repository for the MagicBees Minecraft mod - a Forestry addon.
Do What The F*ck You Want To Public License
20 stars 18 forks source link

Fix ThermalExpansion being loaded before init #11

Closed olavim closed 7 years ago

olavim commented 7 years ago

IntegrationThermalExpansion#L25 was sometimes being called before ItemRegistry was initialized, which resulted drops in

ItemEnumBased<EnumDropType> drops = ItemRegister.dropItem;

being null.

Adding a soft after-dependency for thermalexpansion seems to have fixed this.

This should fix issue #6

Elec332 commented 7 years ago

This is not a way to fix this, the problem was that the FMLInitEvt was called on some modules before it was called on the main mod, this is because the Guava EventBus does not respect the register order. This will be fixed in an upcoming ElecCore release.

olavim commented 7 years ago

It seems like I just got lucky anyway. I could start the game 10 times without crashes, but now I'm getting them again. So yeah, not a fix.