However, that commit missed the fact that ALL the drop chances in that file needed to be adjusted. The addDefaultDrops function adds the "normal" hive drop with a chance of 80 rather than 0.80, and a rain-resistant version of the bee with a chance of 15 or 20 instead of 0.15 or 0.20. And Infernal beehives have a chance of 3 for dropping Steadfast bees, which should have been 0.03, and so on and so forth. ALL the drop rates in that file are wrong, not just the Valiant ones. This means that Steadfast bees will drop from Infernal beehives 50% of the time (they'll be a guaranteed drop if their hive drop gets shuffled into first position, which is a 50% chance for Infernal beehives), rather than 3% of the time as originally intended.
It doesn't look like this particular bug exists in the 1.7.10 code, since that code still used ints between 1 and 100 (actually between 0 and 99) for its percentage chance. But I have anecdotal evidence that suggests that something weird is going on with rain resistance and hive drops in 1.7.10: my wife is currently starting up a Foresty+Extra Bees+Magic Bees playthrough in 1.7.10, and it seems like every single Mystical bee she has found in hives, both princesses and drones, has had the Tolerant Flyer / rain-resistance trait. I.e., it looks like she's getting 100% rain-resistance drop rate rather than 15%, and this is out of a dozen or so Mystical princesses found in hives.
Now, this could just be her getting ridiculously lucky with the RNG, so it's not proof that a bug exists. But it does seem likely that there's something buggy going on with Mystical bees and the rain-resistant trait in the 1.7.10 code. And I know that there's a bug in the 1.10/1.11 branch.
https://github.com/ForestryMC/MagicBees/commit/ed52f547c7e259752226c568907ed4bd2c1b24df recently fixed the bug where Valiant bees were dropping way too often, because the drop chance was 5 instead of 0.05. (It had been changed at some point from a 0-100 int chance to a 0-1 float chance).
However, that commit missed the fact that ALL the drop chances in that file needed to be adjusted. The
addDefaultDropsfunction adds the "normal" hive drop with a chance of 80 rather than 0.80, and a rain-resistant version of the bee with a chance of 15 or 20 instead of 0.15 or 0.20. And Infernal beehives have a chance of 3 for dropping Steadfast bees, which should have been 0.03, and so on and so forth. ALL the drop rates in that file are wrong, not just the Valiant ones. This means that Steadfast bees will drop from Infernal beehives 50% of the time (they'll be a guaranteed drop if their hive drop gets shuffled into first position, which is a 50% chance for Infernal beehives), rather than 3% of the time as originally intended.It doesn't look like this particular bug exists in the 1.7.10 code, since that code still used ints between 1 and 100 (actually between 0 and 99) for its percentage chance. But I have anecdotal evidence that suggests that something weird is going on with rain resistance and hive drops in 1.7.10: my wife is currently starting up a Foresty+Extra Bees+Magic Bees playthrough in 1.7.10, and it seems like every single Mystical bee she has found in hives, both princesses and drones, has had the Tolerant Flyer / rain-resistance trait. I.e., it looks like she's getting 100% rain-resistance drop rate rather than 15%, and this is out of a dozen or so Mystical princesses found in hives.
Now, this could just be her getting ridiculously lucky with the RNG, so it's not proof that a bug exists. But it does seem likely that there's something buggy going on with Mystical bees and the rain-resistant trait in the 1.7.10 code. And I know that there's a bug in the 1.10/1.11 branch.