search

ForeverAndEverTeam / fae-mod

In "Forever & Ever", you can become closer to Sayori than ever before! You have all the time in the world to build the perfect relationship with our cinnamon bun as the star of the show.
Other
50 stars 18 forks source link

Game crashes on Certain Dialog Conversations #6

Closed Pokemiah closed 6 years ago

Pokemiah commented 6 years ago

I was just playing the mod when it suddenly crashed on me. After double-checking the conversation, which is the Archetype conversation located in the Personality section on the Repeat Conversation menu, it turns out that the dialog for it crashes the game around the third line. Here is what the traceback tells me:

[code]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/new_screens.rpy", line 270, in script call
    call screen talk_ui()
  File "game/new_screens.rpy", line 283, in script call
    call screen topic_ui(subscreen)
  File "game/topics.rpy", line 177, in script call
    call expression topic pass (*args, **kwargs)
  File "game/topics.rpy", line 258, in script
    if persistent.last_playthrough > 0 or persistent.seen_topiics.get("s_topics_personal_depression"):
  File "game/topics.rpy", line 258, in <module>
    if persistent.last_playthrough > 0 or persistent.seen_topiics.get("s_topics_personal_depression"):
AttributeError: 'NoneType' object has no attribute 'get'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/new_screens.rpy", line 270, in script call
    call screen talk_ui()
  File "game/new_screens.rpy", line 283, in script call
    call screen topic_ui(subscreen)
  File "game/topics.rpy", line 177, in script call
    call expression topic pass (*args, **kwargs)
  File "game/topics.rpy", line 258, in script
    if persistent.last_playthrough > 0 or persistent.seen_topiics.get("s_topics_personal_depression"):
  File "C:\Users\Jeremiah\Desktop\Game\PC\Steam Games\Doki Doki Literature Club\Modded Games\Doki Doki Forever and Ever\Doki Doki Literature Club\renpy\ast.py", line 1656, in execute
    if renpy.python.py_eval(condition):
  File "C:\Users\Jeremiah\Desktop\Game\PC\Steam Games\Doki Doki Literature Club\Modded Games\Doki Doki Forever and Ever\Doki Doki Literature Club\renpy\python.py", line 1749, in py_eval
    return py_eval_bytecode(code, globals, locals)
  File "C:\Users\Jeremiah\Desktop\Game\PC\Steam Games\Doki Doki Literature Club\Modded Games\Doki Doki Forever and Ever\Doki Doki Literature Club\renpy\python.py", line 1743, in py_eval_bytecode
    return eval(bytecode, globals, locals)
  File "game/topics.rpy", line 258, in <module>
    if persistent.last_playthrough > 0 or persistent.seen_topiics.get("s_topics_personal_depression"):
AttributeError: 'NoneType' object has no attribute 'get'

Windows-8-6.2.9200
Ren'Py 6.99.12.4.2187
Forever & Ever 0.1.1
[/code]

To me it kind of looks like a null reference error that can be easily fixed but I figured it was worth mentioning since it causes the game to crash consistently. Also in the repeat conversation menu specifically in the personality section it constantly repeats the back button making the menu go off screen with no way to scroll it and it could become a problem further down the line. By the way you're doing pretty good so far with the mod. I especially like the writing you're doing on Sayori's character thus far.

EDIT: A little bit later I found a second conversation that crashed the game: the Guitar conversation in the hobbies section. Here is the traceback:

[code]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/new_screens.rpy", line 270, in script call
    call screen talk_ui()
  File "game/new_screens.rpy", line 283, in script call
    call screen topic_ui(subscreen)
  File "game/topics.rpy", line 177, in script call
    call expression topic pass (*args, **kwargs)
  File "game/topics.rpy", line 476, in script
    if persistent.currentmusic > 0 and < persistent.currentmusic < 6:
SyntaxError: invalid syntax (game/topics.rpy, line 476)

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/new_screens.rpy", line 270, in script call
    call screen talk_ui()
  File "game/new_screens.rpy", line 283, in script call
    call screen topic_ui(subscreen)
  File "game/topics.rpy", line 177, in script call
    call expression topic pass (*args, **kwargs)
  File "game/topics.rpy", line 476, in script
    if persistent.currentmusic > 0 and < persistent.currentmusic < 6:
  File "C:\Users\Jeremiah\Desktop\Game\PC\Steam Games\Doki Doki Literature Club\Modded Games\Doki Doki Forever and Ever\Doki Doki Literature Club\renpy\ast.py", line 1656, in execute
    if renpy.python.py_eval(condition):
  File "C:\Users\Jeremiah\Desktop\Game\PC\Steam Games\Doki Doki Literature Club\Modded Games\Doki Doki Forever and Ever\Doki Doki Literature Club\renpy\python.py", line 1748, in py_eval
    code = py_compile(code, 'eval')
  File "C:\Users\Jeremiah\Desktop\Game\PC\Steam Games\Doki Doki Literature Club\Modded Games\Doki Doki Forever and Ever\Doki Doki Literature Club\renpy\python.py", line 584, in py_compile
    raise e
SyntaxError: invalid syntax (game/topics.rpy, line 476)

Windows-8-6.2.9200
Ren'Py 6.99.12.4.2187
Forever & Ever 0.1.1
[/code]

Also the back button repeating seems to extend to the entire repeat conversations menu. I hope this helps you out. If I find any other bugs I'll put them if it's another conversation crash but if it's something else entirely I might make it a separate issue.

AlexanDDOS commented 6 years ago

Thanks for the issue. I'll fix it all in the next version.

AlexanDDOS commented 6 years ago

The needed fixes is already in the repository, so you just need to wait a bit for the next release.