ForeverZer0 / SharpNBT

A pure CLS-compliant C# implementation of the Named Binary Tag (NBT) format specification commonly used with Minecraft applications, allowing easy reading/writing streams and serialization to other formats.
MIT License
25 stars 9 forks source link

Consolidate and remove superfluous abstractions #15

Closed ForeverZer0 closed 1 year ago

ForeverZer0 commented 1 year ago

There is a few types in he library that seem to be abstractions for the sake of abstraction, and do not provide anything beneficial. While they do provide a common "parent" to classes like Compound/List, the actual need for such an abstraction is dubious in practical application, and an existing interface such as IEnumerable would suffice if such a need existed.

Being tied to a common concrete class makes both types less flexible.

ForeverZer0 commented 1 year ago

Complete with 95af348