ForeverZer0 / SharpNBT

A pure CLS-compliant C# implementation of the Named Binary Tag (NBT) format specification commonly used with Minecraft applications, allowing easy reading/writing streams and serialization to other formats.
MIT License
25 stars 9 forks source link

Remove BoolTag #17

Closed ForeverZer0 closed 1 year ago

ForeverZer0 commented 1 year ago

The BoolTag is an addition to this library that does not exist in the spec. This proposal is to remove it completely, and merge its little functionality into ByteTag with additional IsBool and BoolValue properties, as well as a constructor that accepts a boolean.

When reading from binary, it is impossible to differentiate from a ByteTag, so its only purpose is really for display when parsed from SNBT. That small functionality can be easily achieved by the ByteTag class.

ForeverZer0 commented 1 year ago

Boolean functionality has been added to ByteTag, and BoolTag marked as obsolete with 7f99b38