ForgeFlow / ddmrp

DDMRP
GNU Affero General Public License v3.0
14 stars 17 forks source link

11.0 mig ddmrp product replace #51

Closed grindtildeath closed 6 years ago

grindtildeath commented 6 years ago

Depends on :

Todo :

grindtildeath commented 6 years ago

@lreficent @jbeficent I just added a test where I'm not sure if the result is correct as I'm missing context.

I used the 'Copy put away strategy' feature, and when checking if the new product has the same putaway strategy than the old product, it appears the putaway strategy was moved (instead of copied) from old product to new product. Is this correct or should we ensure a copy is done (instead of move) ?

LoisRForgeFlow commented 6 years ago

@grindtildeath nice catch, It's better if the put away strategy is copied to the new product.

grindtildeath commented 6 years ago

@lreficent Thanks for your answer. I suppose we can now remove work in progress and wait reviews :)

LoisRForgeFlow commented 6 years ago

@grindtildeath Really appreciate the migration but we still need to merge a lot of dependencies for ddmrp, ddmrp itself and then this, so I fear this will have to wait for some time :sweat_smile:

LoisRForgeFlow commented 6 years ago

This is weird, I cannot fin this branch in you repo @grindtildeath https://github.com/grindtildeath/ddmrp/branches

grindtildeath commented 6 years ago

@lreficent That happens because grindtildeath/ddmrp is a fork of OCA/ddmrp as I did fork OCA's before Eficent's. The branch you're looking for is on grindtildeath/ddmrp-1 : https://github.com/grindtildeath/ddmrp-1/tree/11.0-mig-ddmrp_product_replace :wink:

LoisRForgeFlow commented 6 years ago

@grindtildeath that's right, thanks!