search

ForgeFlow / ddmrp

DDMRP
GNU Affero General Public License v3.0
14 stars 17 forks source link

[11.0][IMP] ddmrp: more robust buffer status computation on PO lines. #68

Closed max3903 closed 6 years ago

max3903 commented 6 years ago

Supersedes #63

CC: @lreficent @jbeficent @jgrandguillaume

jgrandguillaume commented 6 years ago

@lreficent Can you please relaunch Travis ? We're kind of block because of the red Travis flag..

LoisRForgeFlow commented 6 years ago

Thanks guys! Just let me inform you with our "merging order" as to say:

  1. https://github.com/mpanarin/manufacture/pull/1 will make work 2.
  2. https://github.com/OCA/manufacture/pull/254
  3. https://github.com/Eficent/ddmrp/pull/64
  4. This (I see the lint issues present in 3. are fixed here, thanks again).
  5. extra changes still not opened as PR but almost ready.
  6. hopefully Move to OCA finally?

If we don't get an answer on PR 1 by the beggining of next week I plan to supersede PR 2 with a new PR to try to move forward

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 60.874% when pulling 6c2117038eecfb7cf3ab8181ccb6f3c3363cf7de on camptocamp:11.0-purchase-orderpoint into 8f684a1a5c31430976da41330efadf8d009d672d on Eficent:11.0.

codecov-io commented 6 years ago

Codecov Report

Merging #68 into 11.0 will decrease coverage by 0.04%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             11.0      #68      +/-   ##
==========================================
- Coverage   60.91%   60.87%   -0.05%     
==========================================
  Files          20       20              
  Lines         962      961       -1     
==========================================
- Hits          586      585       -1     
  Misses        376      376
Impacted Files Coverage Δ
ddmrp/models/mrp_bom.py 90.8% <100%> (ø) :arrow_up:
ddmrp/models/stock_warehouse_orderpoint.py 81.15% <28.57%> (ø) :arrow_up:
ddmrp/models/purchase_order.py 75% <85.71%> (-1.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f684a1...6c21170. Read the comment docs.