[16][ADD] rma_category

[florian-dacosta]

Add the possibility to add one or more categories on RMA

[codecov-commenter]

Codecov Report

Merging #458 (8bcda1c) into 16.0 (282987b) will increase coverage by 0.05%. The diff coverage is 100.00%.

Additional details and impacted files

[](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) ```diff @@ Coverage Diff @@ ## 16.0 #458 +/- ## ========================================== + Coverage 80.98% 81.04% +0.05% ========================================== Files 124 128 +4 Lines 4807 4822 +15 Branches 779 779 ========================================== + Hits 3893 3908 +15 Misses 701 701 Partials 213 213 ``` | [Files](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) | Coverage Δ | | |---|---|---| | [rma\_category/\_\_init\_\_.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hX2NhdGVnb3J5L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [rma\_category/models/\_\_init\_\_.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hX2NhdGVnb3J5L21vZGVscy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [rma\_category/models/rma\_category.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hX2NhdGVnb3J5L21vZGVscy9ybWFfY2F0ZWdvcnkucHk=) | `100.00% <100.00%> (ø)` | | | [rma\_category/models/rma\_order\_line.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hX2NhdGVnb3J5L21vZGVscy9ybWFfb3JkZXJfbGluZS5weQ==) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). Last update [282987b...8bcda1c](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent).

[florian-dacosta]

LGTM, I would appreciate a test, but as long as there is no logic we can skip that.

Indeed, there are not logic at all, just a way to classify the RMA with a M2O. I would not know which test I could do for now !

[florian-dacosta]

LGTM including the fix in RMA view. Can you please put the RMA change in a separate commit? Also, the readme won't be created automatically by the content in the readme folder, so I am afraid you have to do it :'(

I did a separate commit. About the README, I made the change already 2 days ago.

[florian-dacosta]

Well, pre-commit fails suddenly, I have no idea why...

[AaronHForgeFlow]

I will check that, perhaps we have to update pre-commit version

[AaronHForgeFlow]

It seems related to change in python version in github actions:

https://github.com/OCA/oca-addons-repo-template/pull/214

[AaronHForgeFlow]

@florian-dacosta if you rebase it should be green now.

[florian-dacosta]

Great, thanks !