search

ForgeFlow / stock-rma

Stock RMA
GNU Affero General Public License v3.0
38 stars 41 forks source link

[16][IMP] Remove deprecated domain from onchange method and put it in field view #490

Closed florian-dacosta closed 10 months ago

florian-dacosta commented 10 months ago

Domain in onchange have been deprecated for a while and it generates this kind of warning : onchange method RmaOrderLine._onchange_product_id returned a domain, this is deprecated

Also, it is not perfect, because it does not apply in case there is no change on the product. (If I open an existing rma order line with a product, I can choose any lot, because the onchange was not played.

And there is already an xml domain in an other rma.order.line view : https://github.com/ForgeFlow/stock-rma/blob/16.0/rma/views/rma_order_view.xml#L195

So I don't see any reason not to remove this onchange domain, unless I am missing something ?

@AaronHForgeFlow FYI

AaronHForgeFlow commented 10 months ago

I agree, Let's remove that.