ForgeFlow / stock-rma

Stock RMA
GNU Affero General Public License v3.0
38 stars 41 forks source link

[17.0][MIG] rma: migration to 17.0 #502

Closed CarlosVForgeFlow closed 5 months ago

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 76.06635% with 404 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (17.0@4c64b8e). Click here to learn what that means.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502/graphs/tree.svg?width=650&height=150&src=pr&token=hagShlnibr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent)](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) ```diff @@ Coverage Diff @@ ## 17.0 #502 +/- ## ======================================= Coverage ? 76.06% ======================================= Files ? 21 Lines ? 1688 Branches ? 337 ======================================= Hits ? 1284 Misses ? 318 Partials ? 86 ``` | [Files](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) | Coverage Δ | | |---|---|---| | [rma/\_\_init\_\_.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [rma/models/\_\_init\_\_.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [rma/models/product.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2Fproduct.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9wcm9kdWN0LnB5) | `100.00% <100.00%> (ø)` | | | [rma/models/product\_category.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2Fproduct_category.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9wcm9kdWN0X2NhdGVnb3J5LnB5) | `100.00% <100.00%> (ø)` | | | [rma/models/res\_company.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2Fres_company.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9yZXNfY29tcGFueS5weQ==) | `100.00% <100.00%> (ø)` | | | [rma/models/res\_config\_settings.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2Fres_config_settings.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9yZXNfY29uZmlnX3NldHRpbmdzLnB5) | `100.00% <100.00%> (ø)` | | | [rma/tests/\_\_init\_\_.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Ftests%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL3Rlc3RzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [rma/wizards/\_\_init\_\_.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fwizards%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL3dpemFyZHMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [rma/models/procurement\_group.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2Fprocurement_group.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9wcm9jdXJlbWVudF9ncm91cC5weQ==) | `93.33% <93.33%> (ø)` | | | [rma/models/res\_partner.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree&filepath=rma%2Fmodels%2Fres_partner.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9yZXNfcGFydG5lci5weQ==) | `86.66% <86.66%> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). Last update [4c64b8e...b3099bb](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/502?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent).
JordiBForgeFlow commented 7 months ago

@AaronHForgeFlow can you review?

AaronHForgeFlow commented 5 months ago

@CarlosVForgeFlow can you please include this https://github.com/ForgeFlow/stock-rma/pull/506?

AaronHForgeFlow commented 5 months ago

Edit: this is happening in other RMA versions so we can leave is as known issue for now:

When activating rma groups and creating an RMA group, when going to the lines the customer is not passed to the lines: image

image

Also, when setting a default operation in the RMA group, it is not passed to the lines on the creation.

AaronHForgeFlow commented 5 months ago

Functional tests are good so far, tested full flow of receptions and deliveries with different locations involved. Pending to test with more complex route configurations. Also I want to test the the accounting cost of the products returned back to stock.