search

ForgeFlow / stock-rma

Stock RMA
GNU Affero General Public License v3.0
38 stars 41 forks source link

[16.0][IMP] rma: create incoming shipment from rma group #508

Open chafique-delli opened 6 months ago

chafique-delli commented 6 months ago

Everything that is created via the wizards at the level of an RMA line, we wish to do at the level of the RMA group, namely:

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.56%. Comparing base (3c0e9c4) to head (4e82915).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508/graphs/tree.svg?width=650&height=150&src=pr&token=hagShlnibr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent)](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) ```diff @@ Coverage Diff @@ ## 16.0 #508 +/- ## ========================================== - Coverage 80.58% 80.56% -0.03% ========================================== Files 128 128 Lines 4889 4898 +9 Branches 794 796 +2 ========================================== + Hits 3940 3946 +6 - Misses 728 730 +2 - Partials 221 222 +1 ``` | [Files](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) | Coverage Δ | | |---|---|---| | [rma/models/rma\_order.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL21vZGVscy9ybWFfb3JkZXIucHk=) | `79.78% <100.00%> (+0.55%)` | :arrow_up: | | [rma/wizards/rma\_make\_picking.py](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent#diff-cm1hL3dpemFyZHMvcm1hX21ha2VfcGlja2luZy5weQ==) | `77.21% <50.00%> (-1.36%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). Last update [3c0e9c4...4e82915](https://app.codecov.io/gh/ForgeFlow/stock-rma/pull/508?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eficent).
chafique-delli commented 5 months ago

@AaronHForgeFlow , @JordiBForgeFlow , Please, I would like to have your opinion on processing RMA lines from the RMA group.

AaronHForgeFlow commented 5 months ago

@chafique-delli I have not looked much into the code. But the idea of being able to generate a single receipts/deliveries/refunds for a RMA group seems like a good feature to me.

chafique-delli commented 5 months ago

@chafique-delli I have not looked much into the code. But the idea of being able to generate a single receipts/deliveries/refunds for a RMA group seems like a good feature to me.

Ok, if that suits you, I will continue in this direction. THANKS

chafique-delli commented 4 months ago

@sebastienbeau , @florian-dacosta , @AaronHForgeFlow , a review please.

chafique-delli commented 3 months ago

Tested so far:

  • create a single receipt order to process several RMA Group lines
  • create a single delivery order to process several RMA Group lines

It works good. Thanks. Do you plan to continue?

I have completed the changes planned for the RMA Group.

AaronHForgeFlow commented 3 months ago

Thank you @chafique-delli I will review it soon

AaronHForgeFlow commented 3 months ago

@chafique-delli Thank you for the work, only a couple of things:

The refunds for the groups are created good, but for some reason the button in the rma group that takes the user to the created refund it is not working, it does nothing:

image

The sale order creation is correct, and linked correctly to the rma lines of the group. I think a small but nice addition here is to be able to access the generated sales order directly from the group, same as we do for the incoming shipments, deliveries or refunds. Do you think you can do it?

image

Aside from this. I think the only think pending is the discussion about the conditions on the displaying of the buttons.

chafique-delli commented 3 months ago

Aside from this. I think the only think pending is the discussion about the conditions on the displaying of the buttons.

@AaronHForgeFlow , thanks for the review. For the 'Refunds' button, I'll see why it doesn't work. For 'Sales' button, I will look to add this to the rma group.

chafique-delli commented 3 weeks ago

@chafique-delli Thank you for the work, only a couple of things:

The refunds for the groups are created good, but for some reason the button in the rma group that takes the user to the created refund it is not working, it does nothing:

image

The sale order creation is correct, and linked correctly to the rma lines of the group. I think a small but nice addition here is to be able to access the generated sales order directly from the group, same as we do for the incoming shipments, deliveries or refunds. Do you think you can do it?

image

Aside from this. I think the only think pending is the discussion about the conditions on the displaying of the buttons.

@AaronHForgeFlow , for the refund button, it's fixed and I added the smart button for the sales order.