search

ForgeRock / forgeops

ForgeRock platform assets for Kubernetes deployment. Contains the files you need to build your own Docker images and to deploy the ForgeRock Identity Platform on Kubernetes clusters.
Other
169 stars 247 forks source link

include 'initContainers' iff there are init containers specified #533

Closed laverya closed 5 years ago

laverya commented 5 years ago

This change moves the initContainers list entirely inside the if .Values.restore.enabled conditional statement, preventing yaml containing only initContainers: with no contents from being generated. While such yaml is accepted by kubectl, it is not correctly parsed by kustomize causing errors.

Some workflows (such as with Replicated Ship) use kustomize to additionally patch yaml generated by helm charts, and are thus impacted by this. See https://github.com/replicatedhq/ship/issues/800.

wstrange commented 5 years ago

Oh Brilliant Andrew. Sorry for the grief - and thanks for the PR!!!