search

ForgeRock / openam-community-edition

Access Management - AuthN, AuthZ, SSO, Fedaration
https://forgerock.github.io/openam-community-edition/
123 stars 60 forks source link

Cleaned up pull request #28

Closed FireBurn closed 7 years ago

FireBurn commented 7 years ago

The changes for org.forgerock -> org.forgerock.ce were done with the following commands:

grep -rZl "org.forgerock.commons:" | xargs -0 sed -i "s#org.forgerock.commons:#org.forgerock.ce.commons:#g"

grep -rZl "org.forgerock.openam:" | xargs -0 sed -i "s#org.forgerock.openam:#org.forgerock.ce.openam:#g"

grep -rZl "org.forgerock.opendj:" | xargs -0 sed -i "s#org.forgerock.opendj:#org.forgerock.ce.opendj:#g"

BohoCode commented 7 years ago

Ah, sorry, ignore my previous comment. I was only reviewing one commit. Still finding my way round github. We use Atlassian BitBucket Server internally.

FireBurn commented 7 years ago

I'm fairly new to the github way too, I think I'd have to create separate branches to send individual updates

BohoCode commented 7 years ago

@FireBurn Can you see the review comment I left on openam-server-only/pom.xml?

FireBurn commented 7 years ago

The same snippet of XML is repeated in the pom. The two have differing comments. One talks about amAuth.xml the other serviceNames.xml but both are coded for amAuth.xml. My guess was one needed to change. Alternatively the repeated one could be removed.

BohoCode commented 7 years ago

@FireBurn - If you can revert that change and add the commit to the PR I'll merge tomorrow. Thanks for your help on this!

FireBurn commented 7 years ago

Right I think I've removed that commit from my tree and from this pull request - if I find anything else that needs to change I'll try and do each change per branch and have a pull request each