search

ForgeRock / secret-agent

Generate random Kubernetes secrets and optionally store them in a Cloud Secret Manager
Apache License 2.0
17 stars 20 forks source link

Refactor reconcile #159

Closed maxres-fr closed 3 years ago

maxres-fr commented 3 years ago

I find the logic hard to follow, but I assume it works.

I made a few changes last night that should make things a bit simpler. Is there somewhere in particular you find it hard to follow?

maxres-fr commented 3 years ago

Another thought: Would it help to create a secret manager interface type, along with a NoOp implementation. Could it simplify this to just: load/store from secret manager. The NoOp manager does nothing - but has the same interface. Just a thought

I think that's great but should be incorporated during the rework of how secrets for the manager is loaded. What I have stubbed out is an and interface so a NoOp would cut some logic down!