search

ForgeRock / secret-agent

Generate random Kubernetes secrets and optionally store them in a Cloud Secret Manager
Apache License 2.0
17 stars 20 forks source link

fix: add KMSKeyId option to AWS Secrets Manager #227

Closed dnitsch closed 1 year ago

dnitsch commented 2 years ago

Adds the ability to supply own KMS key for secret creation.

Addresses #226

@lee-baines or @jrcast you seem to be still somewhat active on this - any chance of a review on this please?

lee-baines commented 1 year ago

Hi @dnitsch, thanks for the PR. Nice addition

dnitsch commented 1 year ago

Hi @dnitsch, thanks for the PR. Nice addition

Thanks @lee-baines - do you know if it can be approved and a new version released soon - as it is a bit of a blocker for a few projects.

ekartsonakisamido commented 1 year ago

👍

lee-baines commented 1 year ago

Hi, apologies for not getting onto this earlier. I've approve the PR. But we're require signed commits to be able to merge so can you please sign the commit and I can get it merged.

dnitsch commented 1 year ago

Hi, apologies for not getting onto this earlier. I've approve the PR. But we're require signed commits to be able to merge so can you please sign the commit and I can get it merged.

ah sorry rebasing signed now - not sure why it didn't sign as I have it globally enabled... anyway

dnitsch commented 1 year ago

@lee-baines done - and thanks again for your help on this.

dnitsch commented 1 year ago

@lee-baines sorry to come back to this - but do you think you can cut a new version or is that something we should do temporarily to get the latest controller code in?

lee-baines commented 1 year ago

I have published a new release including this change

dnitsch commented 1 year ago

Amazing thanks @lee-baines