search

Forien / foundryvtt-forien-quest-log

This module provides comprehensive Quest Log system for players and Game Masters to use with Foundry Virtual Tabletop
MIT License
21 stars 34 forks source link

[BUG] Window for Module doesn't close after clicking save (or close) for new quests. #105

Open dmkuda opened 3 years ago

dmkuda commented 3 years ago

Module Version: v0.3.0

Describe the bug I'm unable to close the dialogue window after creating a new quest. The modal window appears, allows me to make the quest, but does not close when I click save or "close". Only broke after new version of Foundry.

Foundry Version: Foundry Version: 0.7.6 Game System: Dnd5e

dmkuda commented 3 years ago

Verified that this was the only mod running and same behavior.

rholman-PRFT commented 3 years ago

Confirmed.

Jason-Terry commented 3 years ago

Same here.

velara commented 3 years ago

I've found a fix for this.

If you replace lines 145-148 in quest-form.mjs with: async close(options) { if (this.submitted) { return super.close(options); }

I've been able to get normal functionality.

I should add, this was only possible thanks to the work of JDW on Dice so Nice which had a similar issue.

dmkuda commented 3 years ago

Confirmed.  Thank you!!! On Friday, November 13, 2020, 12:44:07 PM MST, velara notifications@github.com wrote:

I've found a fix for this.

If you replace lines 145-148 in quest-form.mjs with: async close(options) { if (this.submitted) { return super.close(options); }

I've been able to get normal functionality.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.