search

Forien / foundryvtt-forien-quest-log

This module provides comprehensive Quest Log system for players and Game Masters to use with Foundry Virtual Tabletop
MIT License
22 stars 35 forks source link

[BUG] Hiding an objective doesn't hide it #113

Closed scooper4711 closed 3 years ago

scooper4711 commented 3 years ago

Module Version: v0.5.3

Describe the bug Hiding an objective by pressing the "eye-con" doesn't actually hide it from players. I have all my players configured as "trusted players" and they can still see the hidden objectives.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'quest log"
  2. Click on 'new quest' & fill in some info
  3. click on new objective. Fill in info and make it hidden.
  4. The quest should be "active"
  5. log in as a trusted player and view the quest. You can see the objective

Expected behavior Hidden objectives should be visible only to the GM and assistant GMs until such a time as the objective is made visible.

Screenshots

Screen Shot 2020-12-29 at 6 39 15 PM

Browser:

Foundry Version: 0.7.8

Game System: HarnMaster

Additional context Add any other context (like other modules installed) about the problem here.

k-barber commented 3 years ago

@scooper4711 I was having this issue as well until I realized that under the "Manage Quest" tab, the "Allow Players to edit Quest Details" option is ON by default, which meant players could both see the hidden objectives, and see text tagged as "Secret" in the quest description.

I'm assuming that your screenshot is from the player's perspective. I can see that it has the reorder, edit, hide/unhide and delete buttons on the objective, suggesting the players can edit the objectives.

If you turn it off, it should fix the issue

"Allow Players to edit Quest Details" = ON (player's perspective): image

"Allow Players to edit Quest Details" = OFF (player's perspective): image

@Forien I don't know if this option is supposed to be on by default or not, but so far every quest I make seems to have it enabled by default. If this is supposed to be off by default this may be a bug. If this is the expected behavior, I think it would probably be best to make this a module setting. Something like "Allow players to edit quests details by default" or so.

Cheers!

scooper4711 commented 3 years ago

@k-barber - Thanks!! you nailed it!