Forien / foundryvtt-forien-quest-log

This module provides comprehensive Quest Log system for players and Game Masters to use with Foundry Virtual Tabletop
MIT License
22 stars 35 forks source link

[BUG] Quest macros don't work #127

Open AlunAlun opened 3 years ago

AlunAlun commented 3 years ago

Module Version: v0.7.3

Describe the bug Executing a script macro with the code in the wiki does nothing and generates a JS error in the console

To Reproduce Steps to reproduce the behavior:

  1. Create a new script Macro
  2. Enter any example from the wiki, e.g. https://github.com/Forien/foundryvtt-forien-quest-log/wiki/Macros#open-quest-log
  3. Click execute Macro
  4. See error in browser console ("Uncaught (in promise) ReferenceError: Quests is not defined")

Dragging a quest into the macro bar and clicking it works as expected.

Expected behavior The macros to work.

Screenshots Screenshot 2021-07-01 at 15 21 02

Browser:

Brave

Foundry Version: 0.8.7

Game System: DnD5e 1.3.5

More info Hacking around I found that game.modules.get('forien-quest-log').public.questLog.render(true) opens the quest log okay

typhonrt commented 3 years ago

This is not going to work in FQL 0.7.4 which is launching soon.

Please use Hooks.call('ForienQuestLog.Open.QuestLog');

Also check out the active repo for FQL: https://github.com/League-of-Foundry-Developers/foundryvtt-forien-quest-log