search

Forien / foundryvtt-forien-quest-log

This module provides comprehensive Quest Log system for players and Game Masters to use with Foundry Virtual Tabletop
MIT License
21 stars 34 forks source link

Spanish language #43

Closed JJBocanegra closed 4 years ago

JJBocanegra commented 4 years ago

Add spanish translation to the module.

Also I want to comment one thing that I couldn't do properly.

In tab.html the first line uses a composition of two texts that in english sounds good but not at all in Spanish. It's the title in this image: image

In english it's Hidden Quests but in spanish it should be like Quests Hidden, the adjective comes after the noun.

My proposal is to change this line in tab.html from <h1>{{localize (lookup questTypes tab)}} {{localize 'ForienQuestLog.Quests'}}</h1> to <h1>{{localize (lookup questTypes tab)}}</h1>

If you don't want to give up the word Quests, then the ForienQuestLog.QuestTypes could be changed to contain the word there and will do the job too.

Forien commented 4 years ago
  1. Please create PR again, but to translations branch, not master.
  2. I am aware of header issue, it will be changed to format instead of localize in v0.4.0, as I'm not going to make more changes to v0.3.*
JJBocanegra commented 4 years ago

Sorry, I didn't saw the info about the translation branch 😅

And perfect about the header issue, if you need some help with the module I can lend a hand sometimes ;)

Forien commented 4 years ago

Sorry, I didn't saw the info about the translation branch 😅

There was none 😅 I need to add that.