search

Forien / foundryvtt-forien-quest-log

This module provides comprehensive Quest Log system for players and Game Masters to use with Foundry Virtual Tabletop
MIT License
22 stars 35 forks source link

[BUG] Javascript exception when i try to add/customize a reward on foundry 0.7.1 #77

Open p4535992 opened 4 years ago

p4535992 commented 4 years ago

Module Version: v0.5.1

Describe the bug

After created a quest i'm trying to add a reward item (e.g. gold), but i get a javascript exception.

It's seem the mandatory attribute of the entity "_id" is absent, not sure if is some collision between the 0.6.5 and 0.7.1 of foundry.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Journal entries and click on "Quest Log"
  2. Click on "Create new quest"
  3. Create a empty quest with title "test"
  4. Go tot the inactive quest tab
  5. Edit the "test" quest
  6. Go to a compendium (e.g. Trade Goods (SRD) for gold) select a entity and drag and drop on the rewards panel
  7. A javascript exception is launched, but the item show up on the rewards tab

img1

  1. Try to customize the item (e.g. quantity) a javascript exception is launched and you can't modify the item

img1

Expected behavior

No javascript exception and the possibility to edit and customize the reward item like a entity item

Screenshots

I put the screenshot on the steps for reproduce the issue.

Browser:

Chrome

Foundry Version:

Foundry VTT Version: 0.7.1 Operating System: [Linux] How Are You Using Foundry: [Linux,Native Application (Electron), Chrome] Modules Enabled?: yes OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Game System:

Dungeons and Dragons 5th Edition, version 0.96

Additional context

There are many modules installed , but i check out the error in a new world with only the module Quest Log activated.

Forien commented 4 years ago

Customization of rewards isn't yet implemented.

Drag issue might be caused by 0.7.1 changes in API, will need to investigate. Does it only happen when dragging from Compendium, or dragging from world also breaks?

p4535992 commented 4 years ago

Only from compendium, if i import the entity item and then drag and drop the item from the "item directory" on the rewards panel no javascript exception is launched.

Forien commented 4 years ago

Okay, thank you for the report, will investigate, but since bugs for 0.7.X alpha are not a priority at the moment, I will most likely not push any fix, unless other bugfixes will be needed got 0.6.5/0.6.6