search

ForkAwesome / Fork-Awesome

DEPRECATED. A fork of the iconic font and CSS toolkit
https://forkaweso.me
1.32k stars 141 forks source link

Obsolete icons #325

Open TechnologyClassroom opened 3 years ago

TechnologyClassroom commented 3 years ago

I was looking through the icons and noticed that some of them are obsolete as in the referenced website or service does not exist anymore. This may be an incomplete list.

Does anyone else know of any more that could be removed?

Would the removal process simply be to delete the files and remove their references in src/icons/.fontcustom-manifest.json and src/icons/icons.yml?

davidscotson commented 3 years ago

I'd suggest a general policy of not removing icons, so that people can rely on them being there, even if they're doing something odd with them.

FWDekker commented 3 years ago

I concur with @davidscotson. I don't think the demise of Google+ means that the icon can no longer be used. It's perfectly legitimate to have, say, an old blog post about Google+ that contains the icon, or to use the icon in a blog post about a retrospective analysis of Google+.

At the same time I understand that sometimes icons have to be removed for one reason or another. In those cases I think that that should be considered a breaking change, resulting in an increase of the major version of Fork Awesome. (But I don't think this is such a case.)

TechnologyClassroom commented 3 years ago

A task for the 2.0 milestone should be cleaning up obsolete icons.

Vine ended in 2016. Stumbleupon ended in 2018. Google+ ended in 2019.

FWDekker commented 3 years ago

I understand, and it's definitely not my choice to make as a random commenter. But you should be wary that this will mean that older pages may break. For example, Font Awesome have an icon for Viacoin. If Viacoin completely dies out, does that mean the icon will be removed after a few years? What should I do with my archived pages that discuss Viacoin and use the icon extensively? I could just not upgrade, but then my other pages in the same website cannot use newly added icons.

If the point of removing obsolete icons is to reduce space (which I think is an important goal, which is why I think a solution is not straightforward) then it might be an idea to introduce a separate icon pack with obsolete icons, for the sake of backwards compatibility. Or perhaps introduce some sort of mechanism for modularity of icons so I can select which icons to include. (Using a distribution with SVG icons which are downloaded separately?) Though I imagine that would be a huge undertaking, so by no means should you interpret this as a "demand" from me.