search

ForkAwesome / Fork-Awesome

DEPRECATED. A fork of the iconic font and CSS toolkit
https://forkaweso.me
1.32k stars 144 forks source link

Don't use <i but <span #373

Open InfoLibre opened 3 years ago

InfoLibre commented 3 years ago

In all your examples, you say users to write <i class="fa... instead of <span class="fa... You recommand to use span instead of i only at once time on https://forkaweso.me/Fork-Awesome/examples/ The result is that mainly all the projects using Forkawesome are keeping your syntax <i class="fa... and in these cases, the icons are displayed differently, a bit smaller and lower than with a span tag.

Could you change <i by <span in all your examples ?

InfoLibre commented 3 years ago

https://www.google.com/search?q=%3Ci+class%3D%22fa : 867 000 000 results https://www.google.com/search?q=%3Cspan+class%3D%22fa : 30 000 000 results

DougInAMug commented 2 years ago

Hey @InfoLibre , thanks for your suggestion.

I'm not sure why <i> was originally used. I'm happy to look into this and update if worthwhile. Do you have any more technical details about the difference between <i> and <span>?

(p.s. I get 1.090.000.000 hits for i and 43.800.000 for span - interesting difference. Also, I'm not sure what you wanted to show with these differences in search results.)

InfoLibre commented 2 years ago

With <span>:

Capture d’écran du 2021-12-02 21-36-16

With <i>:

Capture d’écran du 2021-12-02 21-40-33

It's weird, I hope I don't have CSS somewhere that might be causing this difference. Anyway, using <i> is not a good choice, <span> would make more sense. I think <i> was used because it's easier to write than <span>.

LuanHimmlisch commented 2 years ago

I always try to use for the sake of good HTML structure. I imagine that the syntax was adopted for its shortness